From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A700ECAAD5 for ; Mon, 5 Sep 2022 18:40:04 +0000 (UTC) Received: from localhost ([::1]:59602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVH0t-0004FU-L7 for qemu-devel@archiver.kernel.org; Mon, 05 Sep 2022 14:40:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVGmk-0005EA-7z; Mon, 05 Sep 2022 14:25:27 -0400 Received: from mail-oa1-x34.google.com ([2001:4860:4864:20::34]:39543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVGmc-0002Ul-3u; Mon, 05 Sep 2022 14:25:23 -0400 Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-11e9a7135easo23061664fac.6; Mon, 05 Sep 2022 11:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=is3tn5AdJgakBvOsRBrXMirFMUoHpbf0MJHFV+HEcdo=; b=g8ajqoPaXh+8CVXL+T2255U2/pGm4gCiEUye7d/9z8konKoplIte4y7dW+AUQw083N 4u+zyvRm9p3tVRWXvCaes1gy+lssnWOH/KnEgBAJGhVu6ab/uD1qjiNVi9Dqqp8GJR6O wqu1NGDYlYXrGvAReELfbX6v4kmu36BEfO7MuZJc1daSD97PdTRMcrCw3BHjV20mR1Vk htrsFjGQr2sVVVx2e454FoZM1vAWJGVdYrlL3xSl02XdK97PhMpZBnKnaae3yp4dfQOo rSdiVTE9XSDsFDAnwdzj5Iut5Rf+tD/qmJ6XPu/vx7U+YFi0ATpDSYVe4StcNvqra7KI jRvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=is3tn5AdJgakBvOsRBrXMirFMUoHpbf0MJHFV+HEcdo=; b=f7XA7ljxaHCSdxz+lI+rcTET0OB4xyvhm2MKwcqdQP5beyvUgPLCVi6EvZr8qJtBEr LPMivO8dcR3uY0+OIZU/BL1pt7zl059rvOtostY2vHybQqGBjcgZGM7QodIZkqV7EP8g WJ5XE/QtW5K+lrO1ygvlXtpAFW58fmsIwDjlhOAy8Kby5DUGDD0LgBXsrZ+y6KCcHKSb Tyx1M/VXNH2I66gqfe2PYIMaDpJsdy1i7uXrj/fVXk/hJIrfn5NBK8mHXbi7dToeGOqA 1rqUInkF/2sm+3fefX84I5O/ccYGV00hzv9fiiQxnIi4pGogerg3RcplaGLkk8A0DLxC CD0w== X-Gm-Message-State: ACgBeo3xBAbFWLNW/UYM5IgleAxQA4FlTTX81TfjsrLdXORgGQr4C6cA F3WeInQTepWhg0GNQD9L5JE= X-Google-Smtp-Source: AA6agR46W3Z1tC6T7kx7KpJMMzcw/l9ADLA6+uOnBC0RtBoV1wNae8r4mc2SFNszHL8cFob1sEb0Hw== X-Received: by 2002:a05:6808:1446:b0:343:33a:875e with SMTP id x6-20020a056808144600b00343033a875emr8759259oiv.79.1662402316247; Mon, 05 Sep 2022 11:25:16 -0700 (PDT) Received: from [192.168.10.102] (200-207-147-180.dsl.telesp.net.br. [200.207.147.180]) by smtp.gmail.com with ESMTPSA id 105-20020a9d0bf2000000b00638ac7ddb77sm4863789oth.10.2022.09.05.11.25.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Sep 2022 11:25:15 -0700 (PDT) Message-ID: <108a2e85-97fa-047e-a28f-679109e84ec3@gmail.com> Date: Mon, 5 Sep 2022 15:25:11 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 06/19] target/ppc: Set OV32 when OV is set Content-Language: en-US To: =?UTF-8?Q?V=c3=adctor_Colombo?= , qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: clg@kaod.org, david@gibson.dropbear.id.au, groug@kaod.org, richard.henderson@linaro.org, matheus.ferst@eldorado.org.br, lucas.araujo@eldorado.org.br, leandro.lupori@eldorado.org.br, lucas.coutinho@eldorado.org.br References: <20220901131756.26060-1-victor.colombo@eldorado.org.br> <20220901131756.26060-7-victor.colombo@eldorado.org.br> From: Daniel Henrique Barboza In-Reply-To: <20220901131756.26060-7-victor.colombo@eldorado.org.br> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:4860:4864:20::34; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x34.google.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.716, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/1/22 10:17, Víctor Colombo wrote: > According to PowerISA: "OV32 is set whenever OV is implicitly set, and > is set to the same value that OV is defined to be set to in 32-bit > mode". > > This patch changes helper_update_ov_legacy to set/clear ov32 when > applicable. > > Signed-off-by: Víctor Colombo > --- Reviewed-by: Daniel Henrique Barboza > target/ppc/int_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c > index d905f07d02..696096100b 100644 > --- a/target/ppc/int_helper.c > +++ b/target/ppc/int_helper.c > @@ -37,9 +37,9 @@ > static inline void helper_update_ov_legacy(CPUPPCState *env, int ov) > { > if (unlikely(ov)) { > - env->so = env->ov = 1; > + env->so = env->ov = env->ov32 = 1; > } else { > - env->ov = 0; > + env->ov = env->ov32 = 0; > } > } >