From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 988E1C677C4 for ; Tue, 10 Jun 2025 17:58:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uP3Eu-0002rY-Pb; Tue, 10 Jun 2025 13:58:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uP3Eq-0002o7-JY for grub-devel@gnu.org; Tue, 10 Jun 2025 13:58:21 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uP3Eo-0001eM-O7 for grub-devel@gnu.org; Tue, 10 Jun 2025 13:58:20 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55AGifp4010507; Tue, 10 Jun 2025 17:58:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=WGKpER Yz7EkJgQjjQ6iFa37a5CLKd32dLhvjfyfpYlU=; b=mX66GrSYRZySrtbrfcky9F 6lxsSIarv88mn0F5l4CMy80jqF+yq+fnaHhD1feFkF1iCNPy3wSgHDFpKU/1aPuN 5uQQ/rDYgUrxFzWd7fAA3OYUYsccU0WYGB/idgAg64il8m+Qs0RH1oE4xEf0OfUg 3wEqxD+UC2EF3xfCJjF/b/1Z/UE/arHl0yIIJv387kIJ6ivWoAzA3wja2Ffnb5Rd 3blC9BtkIJ2sfH2CNTbiTjWhPSFEjImq90p6ix+uDGyn1WwOqSWhkgHaDb4RiW99 +glmfLJiqfbTNYS5UpKJs1LLQBc3s+UQlwkIbIWfgfn6xkvl+azAbZjHMXmgPT+A == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 474dv7fv9b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jun 2025 17:58:16 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55AH6UmX027927; Tue, 10 Jun 2025 17:58:15 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 47518mbk9t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jun 2025 17:58:15 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55AHwEdV30737076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Jun 2025 17:58:14 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4D47558068; Tue, 10 Jun 2025 17:58:14 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 147ED58067; Tue, 10 Jun 2025 17:58:14 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 10 Jun 2025 17:58:13 +0000 (GMT) MIME-Version: 1.0 Date: Tue, 10 Jun 2025 23:28:13 +0530 From: sudhakar To: The development of GNU GRUB Cc: daniel.kiper@oracle.com, Lidong Chen , ross.philipson@oracle.com Subject: Re: [PATCH] lib/LzmaEnc: Validate 'len' before subtracting In-Reply-To: <20250610174742.3320770-1-lidong.chen@oracle.com> References: <20250610174742.3320770-1-lidong.chen@oracle.com> Message-ID: <108faa16e09d71c22bde78ca460c5887@linux.ibm.com> X-Sender: sudhakar@linux.ibm.com X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Sa5ADvglAxJlzmcSkYeyFVC7xjCY3Ucb X-Proofpoint-GUID: Sa5ADvglAxJlzmcSkYeyFVC7xjCY3Ucb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjEwMDE0NCBTYWx0ZWRfX9CBrPhyFDXP1 V/0g8EJ3kiReXnYjwEuZ5lDNcbnlVOabtskNH8Cue2J4Nab1Xi80sZsQw0bAvQ8iteUzfJ+7pFX HA2Q15C4NRUgL80Y8FC5+2fXHB8Hxwazc8Trj0I5iGixKEiOhqd3hGyLU9pM8yeTOsMGuImIYYp iL/5ErMgjBzfpPJwEcouAgLETlfBshI2b5i7M9+++ilAH2Y49eSWHvsDKsfO5o3bewsREW28WG0 gvMGhQ8q+56q35iZLheXyla4RLAYIRrRQjf/ZnwaK4+R2/QrOQVy30wxg9k864TVleDvvMQLIlI vFziE17K8WYBRuFP3joV9aEJNGEvPLVvgQWGlAxnNZ2XKPA/kv8H0Sq5NTBh8BexZLa7rUs7kdR g8SMGYBlmplKGvI067IrbsgSAhMN4Pgk7tHQJjm9gkVMfAyh59I17GYsfEkSNX5fhggBE609 X-Authority-Analysis: v=2.4 cv=CfMI5Krl c=1 sm=1 tr=0 ts=68487238 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=yPCof4ZbAAAA:8 a=taL9QaG2sMbFhw2L2akA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-10_08,2025-06-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1011 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506100144 Received-SPF: pass client-ip=148.163.156.1; envelope-from=sudhakar@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org T24gMjAyNS0wNi0xMCAyMzoxNywgTGlkb25nIENoZW4gdmlhIEdydWItZGV2ZWwgd3JvdGU6Cj4g SW4gTHptYUVuY19Db2RlT25lQmxvY2soKSwgYm90aCBHZXRPcHRpbXVtRmFzdCgpIGFuZCBHZXRP cHRpbXVtKCkKPiByZXR1cm5zIGEgdmFsdWUgb2YgZ3JlYXRlciBvciBlcXVhbCB0byAxLCB3aGlj aCBpcyBhc3NpZ25lZCB0bwo+ICdsZW4nLiBCdXQgc2luY2UgTFpNQV9NQVRDSF9MRU5fTUlOID09 IDIsICdsZW4nIHNob3VsZCBiZSB2YWxpZGF0ZWQKPiBiZWZvcmUgcGVyZm9ybWluZyAibGVuIC0g TFpNQV9NQVRDSF9MRU5fTUlOIiB0byBhdm9pZCB1bmRlcmZsb3cKPiB3aGVuICdsZW4nIGVxdWFs cyB0byAxLgo+IAo+IEZpeGVkOiBDSUQgNTE1MDgKPiAKPiBTaWduZWQtb2ZmLWJ5OiBMaWRvbmcg Q2hlbiA8bGlkb25nLmNoZW5Ab3JhY2xlLmNvbT4KPiAtLS0KPiAgZ3J1Yi1jb3JlL2xpYi9Mem1h RW5jLmMgfCA1ICsrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKykKPiAKPiBk aWZmIC0tZ2l0IGEvZ3J1Yi1jb3JlL2xpYi9Mem1hRW5jLmMgYi9ncnViLWNvcmUvbGliL0x6bWFF bmMuYwo+IGluZGV4IDUyYjMzMTU1OC4uZDc0ZTk2MzAzIDEwMDY0NAo+IC0tLSBhL2dydWItY29y ZS9saWIvTHptYUVuYy5jCj4gKysrIGIvZ3J1Yi1jb3JlL2xpYi9Mem1hRW5jLmMKPiBAQCAtMTg4 MCw2ICsxODgwLDExIEBAIHN0YXRpYyBTUmVzIEx6bWFFbmNfQ29kZU9uZUJsb2NrKENMem1hRW5j ICpwLAo+IEJvb2wgdXNlTGltaXRzLCBVSW50MzIgbWF4UGFja1NpemUKPiAgICAgICAgICBVSW50 MzIgcG9zU2xvdCwgbGVuVG9Qb3NTdGF0ZTsKPiAgICAgICAgICBSYW5nZUVuY19FbmNvZGVCaXQo JnAtPnJjLCAmcC0+aXNSZXBbcC0+c3RhdGVdLCAwKTsKPiAgICAgICAgICBwLT5zdGF0ZSA9IGtN YXRjaE5leHRTdGF0ZXNbcC0+c3RhdGVdOwo+ICsJaWYgKGxlbiA8IExaTUFfTUFUQ0hfTEVOX01J TikKPiArCSAgewo+ICsJICAgIHAtPnJlc3VsdCA9IFNaX0VSUk9SX0RBVEE7Cj4gKwkgICAgcmV0 dXJuIENoZWNrRXJyb3JzKHApOwo+ICsJICB9CgpIaSBMaWRvbmcgQ2hlbiwKCnBsZWFzZSBmaXgg dGhlIGluZGVudGF0aW9uIGlzc3VlIGluIGlmIGNvbmRpdGlvbi4KCnRoYW5rcywKc3VkaGFrYXIK Cj4gICAgICAgICAgTGVuRW5jX0VuY29kZTIoJnAtPmxlbkVuYywgJnAtPnJjLCBsZW4gLSBMWk1B X01BVENIX0xFTl9NSU4sCj4gcG9zU3RhdGUsICFwLT5mYXN0TW9kZSwgcC0+UHJvYlByaWNlcyk7 Cj4gICAgICAgICAgcG9zIC09IExaTUFfTlVNX1JFUFM7Cj4gICAgICAgICAgR2V0UG9zU2xvdChw b3MsIHBvc1Nsb3QpOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KR3J1Yi1kZXZlbCBtYWlsaW5nIGxpc3QKR3J1Yi1kZXZlbEBnbnUub3JnCmh0dHBzOi8v bGlzdHMuZ251Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2dydWItZGV2ZWwK