From: Marcel Holtmann <marcel@holtmann.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: bluetooth: replace schedule_timeout() with
Date: Wed, 21 Jul 2004 08:14:09 +0000 [thread overview]
Message-ID: <1090397648.21683.51.camel@pegasus> (raw)
In-Reply-To: <20040720184510.GA2445@masina>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
Hi Nish,
> > > --- linux-vanilla/drivers/bluetooth/bluecard_cs.c 2004-06-16 05:19:22.000000000 +0000
> > > +++ linux-dev/drivers/bluetooth/bluecard_cs.c 2004-07-10 18:22:58.000000000 +0000
> > > @@ -776,8 +776,7 @@ int bluecard_open(bluecard_info_t *info)
> > > outb(0x80, iobase + 0x30);
> > >
> > > /* Wait some time */
> > > - set_current_state(TASK_INTERRUPTIBLE);
> > > - schedule_timeout(HZ / 100);
> > > + msleep(100);
> >
> > This should be 10.
>
> Thanks, here is the corrected patch:
the patches are still wrong, because of warnings like this:
CC [M] drivers/bluetooth/bluecard_cs.o
drivers/bluetooth/bluecard_cs.c: In function `bluecard_open':
drivers/bluetooth/bluecard_cs.c:779: warning: implicit declaration of function `msleep'
I fixed these warnings and now I have to test if the cards are still working.
Regards
Marcel
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-07-21 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-20 18:45 [Kernel-janitors] Re: bluetooth: replace schedule_timeout() with Domen Puncer
2004-07-20 18:52 ` Nishanth Aravamudan
2004-07-21 8:14 ` Marcel Holtmann [this message]
2004-07-21 16:06 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1090397648.21683.51.camel@pegasus \
--to=marcel@holtmann.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.