All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <damm@opensource.se>
To: linux-ide@vger.kernel.org
Subject: [PATCH] possible typo in ide-disk.c
Date: Thu, 22 Jul 2004 00:22:12 +0200	[thread overview]
Message-ID: <1090448532.9480.3.camel@kubu.opensource.se> (raw)

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]

Hi all,

This sure looks like a typo to me.

/ magnus - not subscribed, please cc.



[-- Attachment #2: linux-2.6.8-rc2-ide_task_no_data_intr_20040722.patch --]
[-- Type: text/x-patch, Size: 1204 bytes --]

--- linux-2.6.8-rc2/drivers/ide/ide-disk.c	2004-07-22 00:01:26.000000000 +0200
+++ linux-2.6.8-rc2-ide_task_no_data_intr_20040722/drivers/ide/ide-disk.c	2004-07-22 00:01:57.000000000 +0200
@@ -1377,25 +1377,25 @@
 		args->handler	   = &task_no_data_intr;
 		return do_rw_taskfile(drive, args);
 
 	case idedisk_pm_standby:	/* Suspend step 2 (standby) */
 		args->tfRegister[IDE_COMMAND_OFFSET] = WIN_STANDBYNOW1;
 		args->command_type = IDE_DRIVE_TASK_NO_DATA;
 		args->handler	   = &task_no_data_intr;
 		return do_rw_taskfile(drive, args);
 
 	case idedisk_pm_idle:		/* Resume step 1 (idle) */
 		args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
 		args->command_type = IDE_DRIVE_TASK_NO_DATA;
-		args->handler = task_no_data_intr;
+		args->handler = &task_no_data_intr;
 		return do_rw_taskfile(drive, args);
 
 	case idedisk_pm_restore_dma:	/* Resume step 2 (restore DMA) */
 		/*
 		 * Right now, all we do is call hwif->ide_dma_check(drive),
 		 * we could be smarter and check for current xfer_speed
 		 * in struct drive etc...
 		 * Also, this step could be implemented as a generic helper
 		 * as most subdrivers will use it
 		 */
 		if ((drive->id->capability & 1) == 0)
 			break;

                 reply	other threads:[~2004-07-21 22:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1090448532.9480.3.camel@kubu.opensource.se \
    --to=damm@opensource.se \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.