On Sat, 2004-07-17 at 21:00, Paul Mackerras wrote:
> The arch/ppc64 stuff mostly looks OK - however I would prefer that you
> created a new arch/ppc64/kernel/hvcs.c (and include/asm-ppc64/hvcs.h)
> rather than tripling the size of the existing hvconsole.c.  There are
> a couple of whitespace nits (missing space after "if" in a couple of
> places), and this:

Paul, I think I've fixed up all your complaints/comments.

I've moved the hvcs arch functions out of arch/ppc64/kernel/hvconsole.c
and into arch/ppc64/kernel/hvcserver.c instead of into a file called
hvcs.c (in order to reduce confusion).  Additionally, since these
functions aren't needed if hvcs isn't installed I decided that hvcserver
might as well be a module as well.

Paul, thanks for taking a look.  Here's the next version of the driver. 
Let me know what you think of this round.

I'm a bit concerned about the section where I pull the CLC out of the
pi_buff.  The casting that is going on there is a bit messy.  Maybe
there is a cleaner way of doing it?  The problem is the first ULong of
pi_buff is the partition id, the second ULong is the unit address, and
from then on is character data representing the CLC.

Ryan S. Arnold
IBM Linux Technology Center