All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] bluetooth/bluecard: replace
Date: Fri, 23 Jul 2004 08:45:24 +0000	[thread overview]
Message-ID: <1090572324.21828.56.camel@pegasus> (raw)
In-Reply-To: <20040722214224.GH2165@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

Hi Nish,

> I am really sorry for this, but I didn't change what I had changed
> before in the compileable patch (msleep(10) instead of mlseep(100)).
> This is the final one, I swear (I think).
> 
> Please find below the corrected version, which compiles without error
> for me.
> 
> I would appreciate any comments from the janitors list. This is one (of
> many) cases where I made a decision about replacing
> 
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(some_time);
> 
> with
> 
> msleep(jiffies_to_msecs(some_time));
> 
> msleep() is not exactly the same as the previous code, but I only did
> this replacement where I thought long delays were *desired*. If this is
> not the case here, then just disregard this patch.

you haven't had to resend the patches. I already applied all of them and
fixed the warning in my tree. And I took the right one for bluecard_cs.

Regards

Marcel



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      reply	other threads:[~2004-07-23  8:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-22 21:42 [Kernel-janitors] [PATCH] bluetooth/bluecard: replace Nishanth Aravamudan
2004-07-23  8:45 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1090572324.21828.56.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.