All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@saftware.de>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: Dan Malek <dan@embeddededge.com>,
	Tom Rini <trini@kernel.crashing.org>,
	linuxppc-embedded@lists.linuxppc.org
Subject: Re: [PATCH] export m8xx_cpm_hostalloc
Date: Sat, 24 Jul 2004 15:04:06 +0200	[thread overview]
Message-ID: <1090674246.3023.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20040723083856.A25212@home.com>

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

Am Fr, den 23.07.2004 schrieb Matt Porter um 17:38:
> On Fri, Jul 23, 2004 at 10:41:36AM -0400, Dan Malek wrote:
> >
> > On Jul 23, 2004, at 10:02 AM, Tom Rini wrote:
> >
> > > Must the driver use hostalloc?  I didn't think that i2c was called so
> > > early that kmalloc/bootmem_alloc() (or so) couldn't be used.
> >
> >
> > Should use ...consistent_alloc()
>
> That doesn't exist in 2.6. Use dma_alloc_coherent().

Thanks, that works, but requires the attached patch. Please apply.

Regards,
Andreas

[-- Attachment #2: dma.diff --]
[-- Type: text/x-patch, Size: 946 bytes --]

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/07/24 14:59:23+02:00 obi@pegasos.saftware.de
#   export __dma_alloc_coherent and __dma_free_coherent (required for CONFIG_NOT_COHERENT_CACHE)
#
# arch/ppc/kernel/dma-mapping.c
#   2004/07/24 14:59:03+02:00 obi@pegasos.saftware.de +2 -1
#   export __dma_alloc_coherent and __dma_free_coherent (required for CONFIG_NOT_COHERENT_CACHE)
#
diff -Nru a/arch/ppc/kernel/dma-mapping.c b/arch/ppc/kernel/dma-mapping.c
--- a/arch/ppc/kernel/dma-mapping.c	2004-07-24 15:00:12 +02:00
+++ b/arch/ppc/kernel/dma-mapping.c	2004-07-24 15:00:12 +02:00
@@ -254,6 +254,7 @@
  no_page:
 	return NULL;
 }
+EXPORT_SYMBOL(__dma_alloc_coherent);

 /*
  * free a page as defined by the above mapping.
@@ -317,7 +318,7 @@
 	       __func__, vaddr);
 	dump_stack();
 }
-EXPORT_SYMBOL(dma_free_coherent);
+EXPORT_SYMBOL(__dma_free_coherent);

 /*
  * Initialise the consistent memory allocation.

  parent reply	other threads:[~2004-07-24 13:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-23 13:49 [PATCH] export m8xx_cpm_hostalloc Andreas Oberritter
2004-07-23 13:51 ` Andreas Oberritter
2004-07-23 14:02 ` Tom Rini
2004-07-23 14:41   ` Dan Malek
2004-07-23 14:42     ` Tom Rini
2004-07-23 15:38     ` Matt Porter
2004-07-23 16:27       ` Dan Malek
2004-07-24 13:04       ` Andreas Oberritter [this message]
2004-07-24 18:52         ` Matt Porter
     [not found] ` <20820601.1090640061250.JavaMail.administrator@RnDserver>
2004-07-24  3:52   ` page fault bharat
2004-07-24 17:16     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1090674246.3023.1.camel@localhost.localdomain \
    --to=obi@saftware.de \
    --cc=dan@embeddededge.com \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=mporter@kernel.crashing.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.