From: Dave Hansen <haveblue@us.ibm.com>
To: Fumitake ABE <fabe@us.fujitsu.com>
Cc: lhms <lhms-devel@lists.sourceforge.net>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Lhms-devel] Re: [PATCH] memory hotplug for ia64 (linux-2.6.7) [0/2]
Date: Tue, 27 Jul 2004 09:38:22 -0700 [thread overview]
Message-ID: <1090946301.9337.588.camel@nighthawk> (raw)
In-Reply-To: <41068115.5020202@us.fujitsu.com>
On Tue, 2004-07-27 at 09:21, Fumitake ABE wrote:
> +#ifndef CONFIG_MEMHOTPLUG
> static struct early_node_data mem_data[NR_NODES] __initdata;
> +#else
> +static struct early_node_data mem_data[NR_NODES];
> +#endif
Instead of having a bunch of #ifdefs, it's best to just use __devinit
and __devinitdata. It will switch on CONFIG_HOTPLUG, but we've used it
in a bunch of places for hotplug CPU and everyone appears to like it.
-- Dave
prev parent reply other threads:[~2004-07-27 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-20 9:18 [PATCH] memory hotplug for ia64 (linux-2.6.7) [0/2] Fumihiro Tersawa
2004-07-22 0:35 ` Fumitake ABE
2004-07-27 16:21 ` Fumitake ABE
2004-07-27 16:38 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1090946301.9337.588.camel@nighthawk \
--to=haveblue@us.ibm.com \
--cc=fabe@us.fujitsu.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.