From: Chris Mason <mason@suse.com>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: writepages drops bh on not uptodate page
Date: Wed, 28 Jul 2004 09:03:39 -0400 [thread overview]
Message-ID: <1091019818.6333.84.camel@watt.suse.com> (raw)
In-Reply-To: <20040728045156.GH15895@dualathlon.random>
On Wed, 2004-07-28 at 00:51, Andrea Arcangeli wrote:
> Hi Andrew,
>
> I think I understood why some ext2 fs corruption still happens even
> after the last i_size fix.
>
> what happened I believe is that the writepages layer got a not a fully
> uptodate page (in turn with bh mapped on top of it), and then right
> before unlocking the page and entering the writeback mode, it freed all
> the bh.
Ahhhh, this really explains it, thanks andrea. I agree your fix should
solve things, but I'm wondering if we shouldn't make readpage[s] do a
wait_on_page_writeback(). That might do a better job of protecting us
from future variations of this problem.
-chris
next prev parent reply other threads:[~2004-07-28 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 4:51 writepages drops bh on not uptodate page Andrea Arcangeli
2004-07-28 5:08 ` Andrew Morton
2004-07-28 13:03 ` Chris Mason [this message]
2004-07-28 13:46 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091019818.6333.84.camel@watt.suse.com \
--to=mason@suse.com \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.