From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Cox <alan@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: Fix ide probe double detection
Date: Thu, 29 Jul 2004 13:22:44 +1000 [thread overview]
Message-ID: <1091071364.13625.37.camel@gaston> (raw)
In-Reply-To: <20040727224629.GA17147@devserv.devel.redhat.com>
On Wed, 2004-07-28 at 08:46, Alan Cox wrote:
> Some devices don't decode master/slave - notably PCMCIA adapters.
> Unfortunately for us some also do, which makes it hard to guess if we
> should probe the slave.
>
> This patch fixes the problem by probing the slave and then using the model
> and serial information to spot undecoded pairs. An additional check is done
> to catch pairs of pre ATA devices just in case.
What about checking if drive->select sticks ? And if that doesn't work,
something like
- select 0
- write a value to reg X
- select 1
- write a different value to reg X
- select 0
- check value
reg X could be nsect or such ...
I don't like relying on drive->id and serial_no, but that may just be
paranoia...
Ben.
next prev parent reply other threads:[~2004-07-29 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 22:46 PATCH: Fix ide probe double detection Alan Cox
2004-07-29 3:22 ` Benjamin Herrenschmidt [this message]
2004-07-29 13:39 ` Alan Cox
2004-07-29 15:56 ` Doug Maxey
2004-07-29 16:02 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091071364.13625.37.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.