Hello,


On Fri, 2004-07-30 at 16:14, Adrian Bunk wrote:
> On Thu, Jul 29, 2004 at 02:52:25PM +0200, Grega Fajdiga wrote:
> 
> > Good day,
> 
> Hi Grega,
> 
> > Please CC me, since I'm not subscribed. 
> > I just tried to compile 2.6.8-rc2-mm1 and got this error:
> > drivers/built-in.o(.text+0x7e369): In function `rivafb_probe'::
> > undefined reference to `riva_create_i2c_busses'
> > drivers/built-in.o(.text+0x7e4c1): In function `rivafb_probe'::
> > undefined reference to `riva_delete_i2c_busses'
> > drivers/built-in.o(.exit.text+0x1ca): In function `rivafb_remove'::
> > undefined reference to `riva_delete_i2c_busses'
> > make: *** [.tmp_vmlinux1] Error 1
> >...
> 
> thanks for this report.
> 
> @Nicolas:
> Your rivafb-i2c-fixes patch in -mm causes this with CONFIG_FB_RIVA_I2C=n 
> (it moves i2c code from inside an #ifdef CONFIG_FB_RIVA_I2C to a place 
> where it isn't guarded by such an #ifdef).

It seems that a wrong patch (an older one) has been integrated in -mm.

I attached the right patch, that I already sent on July 14.

Best regards,

Nicolas