From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Anton Blanchard <anton@samba.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] use for_each_cpu
Date: Mon, 02 Aug 2004 15:59:55 +1000 [thread overview]
Message-ID: <1091401715.24784.3.camel@bach> (raw)
In-Reply-To: <20040801004708.6fa9f6f8.akpm@osdl.org>
On Sun, 2004-08-01 at 17:47, Andrew Morton wrote:
> > Is it worth adding complexity to the cpu
> > notifiers vs just using for_each_cpu?
>
> yup ;) It's only six lines, and it follows the same pattern as is used in,
> say, page_alloc_cpu_notify(). Doing the same thing the same way in
> multiple places is to be preferred, yes?
Yes, and that way is "for_each_cpu".
Andrew, take his patch. You know for_each_cpu is preferred over
for_each_online_cpu unless there's a good reason for the latter.
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
prev parent reply other threads:[~2004-08-02 6:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 6:01 [PATCH] use for_each_cpu Anton Blanchard
2004-08-01 6:08 ` Andrew Morton
2004-08-01 7:27 ` Anton Blanchard
2004-08-01 7:47 ` Andrew Morton
2004-08-01 21:00 ` Anton Blanchard
2004-08-02 5:59 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091401715.24784.3.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.