All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralph Loader <suckfish@ihug.co.nz>
To: davem@redhat.com, pekkas@netcore.fi, yoshfuji@linux-ipv6.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Trivial ipv6 fix.
Date: Mon, 02 Aug 2004 20:12:08 +1200	[thread overview]
Message-ID: <1091434328.16469.5.camel@localhost.localdomain> (raw)

Hi,

ipv6_addr_hash doesn't do what it's comment says.  The comment was
probably what was intended, not that it'll make much difference in
practice.

Cheers,
Ralph.

Signed-off-by: Ralph Loader <suckfish@ihug.co.nz>

--- include/net/addrconf.h.orig	2004-08-02 19:54:07.772297854 +1200
+++ include/net/addrconf.h	2004-08-02 19:55:25.166824746 +1200
@@ -178,8 +178,8 @@
 	 * This will include the IEEE address token on links that support it.
 	 */
 
-	word = addr->s6_addr[2] ^ addr->s6_addr32[3];
-	word  ^= (word>>16);
+	word = addr->s6_addr32[2] ^ addr->s6_addr32[3];
+	word ^= (word >> 16);
 	word ^= (word >> 8);
 
 	return ((word ^ (word >> 4)) & 0x0f);



             reply	other threads:[~2004-08-02  8:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-02  8:12 Ralph Loader [this message]
2004-08-02 13:59 ` [PATCH] Trivial ipv6 fix YOSHIFUJI Hideaki / 吉藤英明
2004-08-03  0:08   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1091434328.16469.5.camel@localhost.localdomain \
    --to=suckfish@ihug.co.nz \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pekkas@netcore.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.