All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Nathan Lynch <nathanl@austin.ibm.com>
Cc: Dipankar Sarma <dipankar@in.ibm.com>,
	V Srivatsa <vatsa@in.ibm.com>,
	Joel Schopp <jschopp@austin.ibm.com>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Zwane Mwaikambo <zwane@linuxpower.ca>
Subject: Re: CPU hotplug broken in 2.6.8-rc2 ?
Date: Tue, 03 Aug 2004 10:13:49 +1000	[thread overview]
Message-ID: <1091492027.424.96.camel@bach> (raw)
In-Reply-To: <1091475519.29556.4.camel@pants.austin.ibm.com>

On Tue, 2004-08-03 at 05:38, Nathan Lynch wrote:
> diff -puN kernel/sched.c~check-for-cpu-offline-in-load_balance kernel/sched.c
> --- 2.6.8-rc2-mm2/kernel/sched.c~check-for-cpu-offline-in-load_balance	2004-08-02 13:12:04.000000000 -0500
> +++ 2.6.8-rc2-mm2-nathanl/kernel/sched.c	2004-08-02 13:12:58.000000000 -0500
> @@ -1405,6 +1405,9 @@ static int load_balance(int this_cpu, ru
>  
>  	spin_lock(&this_rq->lock);
>  
> +	if (unlikely(cpu_is_offline(this_cpu)))
> +		goto out_balanced;
> +

cpu_is_offline() is "unlikely" already.  Please just use "if
(cpu_is_offline(this_cpu))"

Thanks,
Rusty.
-- 
Anyone who quotes me in their signature is an idiot -- Rusty Russell


  parent reply	other threads:[~2004-08-03  0:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-02  9:49 CPU hotplug broken in 2.6.8-rc2 ? Dipankar Sarma
2004-08-02  9:57 ` Dipankar Sarma
2004-08-02 13:46   ` Anton Blanchard
2004-08-02 19:38   ` Nathan Lynch
2004-08-02 20:26     ` Nathan Lynch
2004-08-03 21:07       ` Nathan Lynch
2004-08-04 10:06         ` Srivatsa Vaddagiri
2004-08-04 13:12           ` Nathan Lynch
2004-08-04 14:50         ` Zwane Mwaikambo
2004-08-04 21:07           ` Con Kolivas
2004-08-03  0:13     ` Rusty Russell [this message]
2004-08-02 16:00 ` Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1091492027.424.96.camel@bach \
    --to=rusty@rustcorp.com.au \
    --cc=dipankar@in.ibm.com \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathanl@austin.ibm.com \
    --cc=nickpiggin@yahoo.com.au \
    --cc=vatsa@in.ibm.com \
    --cc=zwane@linuxpower.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.