All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollisb@us.ibm.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org
Subject: cross-depmod?
Date: Thu, 05 Aug 2004 16:51:56 -0500	[thread overview]
Message-ID: <1091742716.28466.27.camel@localhost> (raw)

Hi Sam, would you take a patch like this:

--- 1.509/Makefile      Tue Aug  3 16:11:35 2004
+++ edited/Makefile     Thu Aug  5 17:12:07 2004
@@ -790,7 +790,11 @@
 endif
 .PHONY: _modinst_post
 _modinst_post: _modinst_
-       if [ -r System.map ]; then $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE); fi
+       if [ -z "$(CROSS_COMPILE)" -o "$(DEPMOD)" != "/sbin/depmod" ] ; then \
+               if [ -r System.map ]; then \
+                       $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE); \
+               fi \
+       fi

 else # CONFIG_MODULES

(I don't like hardcoding /sbin/depmod; this is just for conversation.)

My problem is that I cross-build my kernels, and 'make rpm' is very
unhappy when it can't use depmod. I know that I can do 'make
DEPMOD=/bin/true rpm', but can't we figure that out automatically?

In general if you're cross-compiling I don't think you can assume
/sbin/depmod is ok. Someone could do 'make DEPMOD=powerpc-linux-depmod'
though (couldn't they? does anybody bother?), so if $(DEPMOD) has been
specified we still want to let that work...

-- 
Hollis Blanchard
IBM Linux Technology Center


             reply	other threads:[~2004-08-05 21:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-05 21:51 Hollis Blanchard [this message]
2004-08-06  8:40 ` cross-depmod? David Vrabel
2004-08-06 13:45   ` cross-depmod? Geert Uytterhoeven
2004-08-06 15:17     ` cross-depmod? Sam Ravnborg
2004-08-06 15:42 ` cross-depmod? Sam Ravnborg
2004-08-08 23:05   ` cross-depmod? Rusty Russell
2004-08-09  6:15     ` cross-depmod? Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1091742716.28466.27.camel@localhost \
    --to=hollisb@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.