From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 0/3] drm: Add various helpers for simple drivers Date: Thu, 12 May 2016 22:05:37 +0300 Message-ID: <10920756.EEokP9U6oI@avalon> References: <1463077523-23959-1-git-send-email-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id C07726E07B for ; Thu, 12 May 2016 19:05:37 +0000 (UTC) In-Reply-To: <1463077523-23959-1-git-send-email-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgTm9yYWxmLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2hlcy4KCkZvciAxLzMgYW5kIDIvMywK ClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25i b2FyZC5jb20+CgpPbiBUaHVyc2RheSAxMiBNYXkgMjAxNiAyMDoyNToyMCBOb3JhbGYgVHLDuG5u ZXMgd3JvdGU6Cj4gVGhpcyBwYXRjaHNldCBhZGRzIHZhcmlvdXMgaGVscGVycyB0aGF0IHdhcyBv cmlnaW5hbGx5IHBhcnQgb2YgdGhlCj4gdGlueWRybSBwYXRjaHNldC4KPiAKPiBFc3NlbnRpYWxs eSBpdCBhZGRzIDIgZnVuY3Rpb25zOgo+IC0gZHJtX2ZiX2NtYV9jcmVhdGVfd2l0aF9mdW5jcygp Cj4gICBDTUEgYmFja2VkIGZyYW1lYnVmZmVyIHN1cHBvcnRpbmcgYSBkaXJ0eSgpIGNhbGxiYWNr Lgo+IC0gZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGVfaW5pdCgpCj4gICBQbGFuZSwgY3J0YyBhbmQg ZW5jb2RlciBhcmUgY29sbGFwc2VkIGludG8gb25lIGVudGl0eS4KPiAKPiAKPiBDaGFuZ2VzIHNp bmNlIHYzOgo+IC0gQWRkIHBhdGNoICdkcm0vZmItY21hLWhlbHBlcjogVXNlIGNvbnN0IGZvciBk cm1fZnJhbWVidWZmZXJfZnVuY3MKPiBhcmd1bWVudCcgLSBkcm0vZmItY21hLWhlbHBlcjogQWRk IGZ1bmN0aW9uIGRybV9mYl9jbWFfY3JlYXRlX3dpdGhfZnVuY3MoKQo+ICAgLSBmdW5jcyBhcmd1 bWVudCBzaG91bGQgYmUgY29uc3QKPiAtIGRybTogQWRkIGhlbHBlciBmb3Igc2ltcGxlIGRpc3Bs YXkgcGlwZWxpbmUKPiAgIC0gKHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSAqKS0+ZnVu Y3Mgc2hvdWxkIGJlIGNvbnN0Cj4gCj4gQ2hhbmdlcyBzaW5jZSB2MjoKPiAtIGRybTogQWRkIGhl bHBlciBmb3Igc2ltcGxlIGRpc3BsYXkgcGlwZWxpbmUKPiAgIC0gRHJvcCBLY29uZmlnIGtub2Ig RFJNX0tNU19IRUxQRVIKPiAgIC0gRXhwYW5kIGRvY3VtZW50YXRpb24KPiAKPiBDaGFuZ2VzIHNp bmNlIHYxOgo+IC0gRHJvcCBwYXRjaDogZHJtL3BhbmVsOiBBZGQgaGVscGVyIGZvciBzaW1wbGUg cGFuZWwgY29ubmVjdG9yCj4gLSBBZGQgZmItaGVscGVyIGFuZCBmYi1jbWEtaGVscGVyIGRvYyBw YXRjaGVzCj4gLSBBZGQgZHJtL2F0b21pYzogRG9uJ3Qgc2tpcCBkcm1fYnJpZGdlXyooKSBjYWxs cyBpZgo+ICFkcm1fZW5jb2Rlcl9oZWxwZXJfZnVuY3MgLSBBZGQgZHJtX2F0b21pY19oZWxwZXJf YmVzdF9lbmNvZGVyKCkKPiAtIGRybS9mYi1jbWEtaGVscGVyOiBBZGQgZnVuY3Rpb24gZHJtX2Zi X2NtYV9jcmVhdGVfd2l0aF9mdW5jcygpCj4gICAtIEV4cGFuZCBkb2NzCj4gLSBkcm06IEFkZCBo ZWxwZXIgZm9yIHNpbXBsZSBkaXNwbGF5IHBpcGVsaW5lCj4gICAtIEFkZCBET0MgaGVhZGVyIGFu ZCBhZGQgdG8gZ3B1LnRtcGwKPiAgIC0gRml4IGRvY3M6IEBmdW5jcyBpcyBvcHRpb25hbCwgIm5l Z2F0aXZlIGVycm9yIGNvZGUiLAo+ICAgICAiVGhpcyBob29rIGlzIG9wdGlvbmFsLiIKPiAgIC0g QWRkIGNoZWNrcyB0byBkcm1fc2ltcGxlX2ttc19wbGFuZV9hdG9taWNfY2hlY2soKQo+IAo+IAo+ IE5vcmFsZiBUcsO4bm5lcyAoMyk6Cj4gICBkcm0vZmItY21hLWhlbHBlcjogVXNlIGNvbnN0IGZv ciBkcm1fZnJhbWVidWZmZXJfZnVuY3MgYXJndW1lbnQKPiAgIGRybS9mYi1jbWEtaGVscGVyOiBB ZGQgZnVuY3Rpb24gZHJtX2ZiX2NtYV9jcmVhdGVfd2l0aF9mdW5jcygpCj4gICBkcm06IEFkZCBo ZWxwZXIgZm9yIHNpbXBsZSBkaXNwbGF5IHBpcGVsaW5lCj4gCj4gIERvY3VtZW50YXRpb24vRG9j Qm9vay9ncHUudG1wbCAgICAgICAgICB8ICAgNiArCj4gIGRyaXZlcnMvZ3B1L2RybS9NYWtlZmls ZSAgICAgICAgICAgICAgICB8ICAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2NtYV9o ZWxwZXIuYyAgICAgfCAgMzUgKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2tt c19oZWxwZXIuYyB8IDIwOAo+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrIGluY2x1 ZGUvZHJtL2RybV9mYl9jbWFfaGVscGVyLmggICAgICAgICB8IAo+ICA1ICstCj4gIGluY2x1ZGUv ZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5oICAgICB8ICA5NCArKysrKysrKysrKysrKysKPiAg NiBmaWxlcyBjaGFuZ2VkLCAzNDAgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmMK PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5o Cj4gCj4gLS0KPiAyLjguMgo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752805AbcELTFi (ORCPT ); Thu, 12 May 2016 15:05:38 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:50538 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbcELTFh convert rfc822-to-8bit (ORCPT ); Thu, 12 May 2016 15:05:37 -0400 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Noralf =?ISO-8859-1?Q?Tr=F8nnes?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] drm: Add various helpers for simple drivers Date: Thu, 12 May 2016 22:05:37 +0300 Message-ID: <10920756.EEokP9U6oI@avalon> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.16; x86_64; ; ) In-Reply-To: <1463077523-23959-1-git-send-email-noralf@tronnes.org> References: <1463077523-23959-1-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Noralf, Thank you for the patches. For 1/3 and 2/3, Reviewed-by: Laurent Pinchart On Thursday 12 May 2016 20:25:20 Noralf Trønnes wrote: > This patchset adds various helpers that was originally part of the > tinydrm patchset. > > Essentially it adds 2 functions: > - drm_fb_cma_create_with_funcs() > CMA backed framebuffer supporting a dirty() callback. > - drm_simple_display_pipe_init() > Plane, crtc and encoder are collapsed into one entity. > > > Changes since v3: > - Add patch 'drm/fb-cma-helper: Use const for drm_framebuffer_funcs > argument' - drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() > - funcs argument should be const > - drm: Add helper for simple display pipeline > - (struct drm_simple_display_pipe *)->funcs should be const > > Changes since v2: > - drm: Add helper for simple display pipeline > - Drop Kconfig knob DRM_KMS_HELPER > - Expand documentation > > Changes since v1: > - Drop patch: drm/panel: Add helper for simple panel connector > - Add fb-helper and fb-cma-helper doc patches > - Add drm/atomic: Don't skip drm_bridge_*() calls if > !drm_encoder_helper_funcs - Add drm_atomic_helper_best_encoder() > - drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() > - Expand docs > - drm: Add helper for simple display pipeline > - Add DOC header and add to gpu.tmpl > - Fix docs: @funcs is optional, "negative error code", > "This hook is optional." > - Add checks to drm_simple_kms_plane_atomic_check() > > > Noralf Trønnes (3): > drm/fb-cma-helper: Use const for drm_framebuffer_funcs argument > drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() > drm: Add helper for simple display pipeline > > Documentation/DocBook/gpu.tmpl | 6 + > drivers/gpu/drm/Makefile | 2 +- > drivers/gpu/drm/drm_fb_cma_helper.c | 35 ++++-- > drivers/gpu/drm/drm_simple_kms_helper.c | 208 > ++++++++++++++++++++++++++++++++ include/drm/drm_fb_cma_helper.h | > 5 +- > include/drm/drm_simple_kms_helper.h | 94 +++++++++++++++ > 6 files changed, 340 insertions(+), 10 deletions(-) > create mode 100644 drivers/gpu/drm/drm_simple_kms_helper.c > create mode 100644 include/drm/drm_simple_kms_helper.h > > -- > 2.8.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Regards, Laurent Pinchart