From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alan Cox <alan@redhat.com>,
linux-ide@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: PATCH: IDE - do spin up for all platforms
Date: Tue, 10 Aug 2004 08:10:38 +1000 [thread overview]
Message-ID: <1092089438.14102.48.camel@gaston> (raw)
In-Reply-To: <411790DE.7010503@pobox.com>
On Tue, 2004-08-10 at 00:57, Jeff Garzik wrote:
> It needs to check for "status != 0x7f" which is the standard "no device
> here" return status.
Nope, it waits for BSY to go down
> But worse than that, status can return 0xFF for "no hardware there", in
> which case this routine will hang the boot for 35 seconds.
My original version did, let me check.. yes, the current code does that
too, check ide_wait_not_busy. Note that this is a workaround for broken
hardware as the spec clearly says that D7 should be pulled low so that
no drive returns 0x7f (BSY clear). However, there is a significant
amount of HW with this bug...
> Note also that libata code does this:
> * wait 7 seconds
> * printk("it's taking a long time, be patient")
> * wait ~30 seconds
That could be a good idea. Patch welcome :)
Ben.
prev parent reply other threads:[~2004-08-09 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 14:39 PATCH: IDE - do spin up for all platforms Alan Cox
2004-08-09 14:57 ` Jeff Garzik
2004-08-09 15:25 ` Alan Cox
2004-08-09 22:10 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092089438.14102.48.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.