From: Rusty Russell <rusty@rustcorp.com.au>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: Olaf Hering <olh@suse.de>, Dave Boutcher <boutcher@us.ibm.com>,
linuxppc64-dev@lists.linuxppc.org,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: module.viomap support for ppc64
Date: Fri, 13 Aug 2004 09:43:15 +1000 [thread overview]
Message-ID: <1092354195.25196.11.camel@bach> (raw)
In-Reply-To: <1092339278.19137.8.camel@localhost>
On Fri, 2004-08-13 at 05:34, Hollis Blanchard wrote:
> On Thu, 2004-08-12 at 12:37, Olaf Hering wrote:
> > Current MODULE_DEVICE_TABLE(vio, $table); defines 2 char pointers. I'm
> > not sure if depmod can really handle it. Where do they point to in the
> > module binary? I could find an answer, so far. I just declared an array.
>
> Olaf explained on irc that output_vio_entry() below was finding NULL for
> the name and compat pointers. Perhaps some additional relocation needs
> to take place before those can be used?
1) Please use char arrays of some fixed size.
2) Please modify scripts/mod/file2alias.c in the kernel source, not the
module tools. The modules.XXXmap files are deprecated: device tables
are supposed to be converted to aliases in the build process, and that
is how userspace tools like hotplug are to find them.
3) I will still accept patches to module-init-tools if required for 2.4
compatibility, but they will be going away at some point!
Hope that clarifies!
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next prev parent reply other threads:[~2004-08-12 23:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-12 17:37 module.viomap support for ppc64 Olaf Hering
2004-08-12 19:34 ` Hollis Blanchard
2004-08-12 23:43 ` Rusty Russell [this message]
2004-08-13 9:40 ` Olaf Hering
2004-08-13 13:42 ` Rusty Russell
2004-08-13 20:22 ` Marcelo Tosatti
2004-08-19 21:28 ` Olaf Hering
2004-08-20 3:47 ` Rusty Russell
2004-08-20 5:57 ` Olaf Hering
2004-08-20 7:25 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092354195.25196.11.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=boutcher@us.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.