Re: [2.6 patch] let W1 select NET

[Evgeniy Polyakov <johnpol@2ka.mipt.ru>]

[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]

On Fri, 2004-08-13 at 14:17, Adrian Bunk wrote:
> W1=y and Net=n fails with the following compile error:
> 
> <--  snip  -->
> 
> ...
>   LD      .tmp_vmlinux1
> drivers/built-in.o(.text+0x5efa38): In function `w1_alloc_dev':
> : undefined reference to `netlink_kernel_create'
> drivers/built-in.o(.text+0x5efac1): In function `w1_alloc_dev':
> : undefined reference to `sock_release'
> drivers/built-in.o(.text+0x5efb31): In function `w1_free_dev':
> : undefined reference to `sock_release'
> drivers/built-in.o(.text+0x5f0014): In function `w1_netlink_send':
> : undefined reference to `alloc_skb'
> drivers/built-in.o(.text+0x5f00cd): In function `w1_netlink_send':
> : undefined reference to `netlink_broadcast'
> drivers/built-in.o(.text+0x5f0131): In function `w1_netlink_send':
> : undefined reference to `skb_over_panic'
> make: *** [.tmp_vmlinux1] Error 1
> 
> <--  snip  -->
> 
> 
> The patch below fixes this issue by letting W1 select NET.

Sure.
W1 requires netlink and thus CONFIG_NET.

Thank you.
I've applied your patch to my tree 
and will send it to GregKH -> Andrew Morton.

> 
> Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
> 
> --- linux-2.6.8-rc4-mm1-full-3.4/drivers/w1/Kconfig.old	2004-08-13 12:00:05.000000000 +0200
> +++ linux-2.6.8-rc4-mm1-full-3.4/drivers/w1/Kconfig	2004-08-13 12:11:31.000000000 +0200
> @@ -2,6 +2,7 @@
>  
>  config W1
>  	tristate "Dallas's 1-wire support"
> +	select NET
>  	---help---
>  	  Dallas's 1-wire bus is usefull to connect slow 1-pin devices 
>  	  such as iButtons and thermal sensors.
-- 
	Evgeniy Polyakov ( s0mbre )

Crash is better than data corruption. -- Art Grabowski

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]