From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>, pj@sgi.com
Subject: [PATCH] Read cpumasks every time when exporting through sysfs
Date: Mon, 16 Aug 2004 11:26:42 +1000 [thread overview]
Message-ID: <1092619602.29608.47.camel@bach> (raw)
Name: Read cpumasks every time when exporting through sysfs
Status: Booted on 2.6.7-rc2-bk7
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Paul Jackson points out that the sysfs code saves a node's cpumask in
the sysfs node, although it can change with CPU hotplug. Don't do
this.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .4860-linux-2.6.7-rc2-bk7/drivers/base/node.c .4860-linux-2.6.7-rc2-bk7.updated/drivers/base/node.c
--- .4860-linux-2.6.7-rc2-bk7/drivers/base/node.c 2004-06-07 07:47:33.000000000 +1000
+++ .4860-linux-2.6.7-rc2-bk7.updated/drivers/base/node.c 2004-06-07 12:26:16.000000000 +1000
@@ -18,7 +18,7 @@ static struct sysdev_class node_class =
static ssize_t node_read_cpumap(struct sys_device * dev, char * buf)
{
struct node *node_dev = to_node(dev);
- cpumask_t mask = node_dev->cpumap;
+ cpumask_t mask = node_to_cpumask(node_dev->sysdev.id);
int len;
/* 2004/06/03: buf currently PAGE_SIZE, need > 1 char per 4 bits. */
@@ -116,7 +116,6 @@ int __init register_node(struct node *no
{
int error;
- node->cpumap = node_to_cpumask(num);
node->sysdev.id = num;
node->sysdev.cls = &node_class;
error = sysdev_register(&node->sysdev);
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .4860-linux-2.6.7-rc2-bk7/include/linux/node.h .4860-linux-2.6.7-rc2-bk7.updated/include/linux/node.h
--- .4860-linux-2.6.7-rc2-bk7/include/linux/node.h 2003-09-22 10:27:37.000000000 +1000
+++ .4860-linux-2.6.7-rc2-bk7.updated/include/linux/node.h 2004-06-07 12:24:47.000000000 +1000
@@ -23,7 +23,6 @@
#include <linux/cpumask.h>
struct node {
- cpumask_t cpumap; /* Bitmap of CPUs on the Node */
struct sys_device sysdev;
};
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next reply other threads:[~2004-08-16 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-16 1:26 Rusty Russell [this message]
2004-08-16 6:08 ` [PATCH] Read cpumasks every time when exporting through sysfs Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092619602.29608.47.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.