From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Alan Cox <alan@redhat.com>,
linux-ide@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@osdl.org
Subject: Re: PATCH: add drive_to_key functions
Date: Mon, 16 Aug 2004 18:38:18 +0100 [thread overview]
Message-ID: <1092677889.20838.36.camel@localhost.localdomain> (raw)
In-Reply-To: <200408161912.26595.bzolnier@elka.pw.edu.pl>
On Llu, 2004-08-16 at 18:12, Bartlomiej Zolnierkiewicz wrote:
> > hwif->atapi_dma = 0; /* disable all atapi dma */
> > hwif->ultra_mask = 0x80; /* disable all ultra */
> > hwif->mwdma_mask = 0x80; /* disable all mwdma */
> > hwif->swdma_mask = 0x80; /* disable all swdma */
> >
> > + hwif->pci_dev = NULL;
> > + hwif->remove = NULL;
> > +
>
> not needed - memsetting to zero is done earlier
Ok fixed in my tree.
> > +EXPORT_SYMBOL_GPL(ide_drive_to_key);
>
> AFAICS ide_drive_[from,to]_key are to be used only from ide-proc.c
> so EXPORT_SYMBOLs are not needed
Good point I forgot they were linked together. Fixed
prev parent reply other threads:[~2004-08-16 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-15 14:58 PATCH: add drive_to_key functions Alan Cox
2004-08-16 17:12 ` Bartlomiej Zolnierkiewicz
2004-08-16 17:38 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1092677889.20838.36.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.