All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Josefsson <gandalf@wlug.westbo.se>
To: Pablo Neira <pablo@eurodev.net>
Cc: Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>,
	Harald Welte <laforge@netfilter.org>,
	Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] return value of conntrack protocol helper functions and a macro for stats
Date: Sat, 21 Aug 2004 23:27:38 +0200	[thread overview]
Message-ID: <1093123658.21593.7.camel@localhost.localdomain> (raw)
In-Reply-To: <1093040122.20712.18.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

On Sat, 2004-08-21 at 00:15, Martin Josefsson wrote:

> > @@ -303,12 +307,13 @@
> >  	unsigned int insert_failed;
> >  	unsigned int drop;
> >  	unsigned int early_drop;
> > -	unsigned int icmp_error;
> > +	unsigned int error;
> >  	unsigned int expect_new;
> >  	unsigned int expect_create;
> >  	unsigned int expect_delete;
> >  };

There's a piece missing:
(hand-made, ymmv)

--- linux.old/net/ipv4/netfilter/ip_conntrack_standalone.c	2004-08-21 23:17:00.548009856 -0400
+++ linux/net/ipv4/netfilter/ip_conntrack_standalone.c	2004-08-21 23:17:00.545555344 -0400
@@ -334,6 +334,6 @@
 		   st->insert_failed,
 		   st->drop,
 		   st->early_drop,
-		   st->icmp_error,
+		   st->error,
 
 		   st->expect_new,
 		   st->expect_create,

-- 
/Martin

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2004-08-21 21:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-05 13:34 [PATCH] return value of conntrack protocol helper functions and a macro for stats Pablo Neira
2004-08-20 22:15 ` Martin Josefsson
2004-08-21 21:27   ` Martin Josefsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1093123658.21593.7.camel@localhost.localdomain \
    --to=gandalf@wlug.westbo.se \
    --cc=kaber@trash.net \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@eurodev.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.