All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Please revert this patch
Date: Thu, 26 Aug 2004 13:57:00 +1000	[thread overview]
Message-ID: <1093492619.2637.67.camel@gaston> (raw)
In-Reply-To: <200408260010.i7Q0A6EB001323@hera.kernel.org>

Hi Linux !

Please revert that for now, I need to figure out what they were
exactly trying to do and will come up with something if it makes
sense but the patch as-is doesn't.

Thanks,
Ben.

On Thu, 2004-08-26 at 06:21, Linux Kernel Mailing List wrote:
> ChangeSet 1.1870.2.2, 2004/08/25 13:21:22-07:00, khali@linux-fr.org
> 
> 	[PATCH] I2C: keywest class
> 	
> 	This is needed for iBook2 owners to be able to use their ADM1030
> 	hardware monitoring chip. Successfully tested by one user.
> 	
> 	Signed-off-by: Jean Delvare <khali@linux-fr.org>
> 	Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
> 
> 
> 
>  i2c-keywest.c |    2 ++
>  1 files changed, 2 insertions(+)
> 
> 
> diff -Nru a/drivers/i2c/busses/i2c-keywest.c b/drivers/i2c/busses/i2c-keywest.c
> --- a/drivers/i2c/busses/i2c-keywest.c	2004-08-25 17:10:16 -07:00
> +++ b/drivers/i2c/busses/i2c-keywest.c	2004-08-25 17:10:16 -07:00
> @@ -618,6 +618,8 @@
>  		chan->iface = iface;
>  		chan->chan_no = i;
>  		chan->adapter.id = I2C_ALGO_SMBUS;
> +		if (i==1)
> +			chan->adapter.class = I2C_CLASS_HWMON;
>  		chan->adapter.algo = &keywest_algorithm;
>  		chan->adapter.algo_data = NULL;
>  		chan->adapter.client_register = NULL;
> -
> To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Benjamin Herrenschmidt <benh@kernel.crashing.org>


           reply	other threads:[~2004-08-26  3:59 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200408260010.i7Q0A6EB001323@hera.kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1093492619.2637.67.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.