From: James Bottomley <James.Bottomley@SteelEye.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: PATCH: (as355) Fix test for valid sense data present
Date: 26 Aug 2004 12:09:20 -0400 [thread overview]
Message-ID: <1093536566.2326.61.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0408261154360.1089-100000@ida.rowland.org>
On Thu, 2004-08-26 at 11:55, Alan Stern wrote:
> It hasn't been applied anywhere that I've looked. Is there any problem
> with it?
Well, it doesn't look quite right.
You haven't modified the SCSI_SENSE_VALID() macro, so DRIVER_SENSE
doesn't get set for the extra conditions you're checking for.
Even if you do fix it, You'll cause us to treat deferred sense
conditions as errors, which would be wrong.
What's the actual problem you're trying to fix?
James
next prev parent reply other threads:[~2004-08-26 16:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-22 16:21 Incorrect response to SK/ASC/ASCQ = x 02/04/01 (becoming ready) Alan Stern
2004-08-22 22:55 ` Nathan Bryant
2004-08-22 23:32 ` James Bottomley
2004-08-22 23:56 ` Burn Alting
2004-08-23 15:31 ` James Bottomley
2004-08-23 17:08 ` Burn Alting
2004-08-26 2:54 ` Jeremy Higdon
2004-08-26 15:38 ` James Bottomley
2004-08-26 22:36 ` Jeremy Higdon
2004-08-27 0:03 ` Douglas Gilbert
2004-08-26 15:55 ` PATCH: (as355) Fix test for valid sense data present Alan Stern
2004-08-26 16:09 ` James Bottomley [this message]
2004-08-26 16:59 ` Alan Stern
2004-08-26 17:27 ` James Bottomley
2004-08-26 19:32 ` Alan Stern
2004-08-26 23:36 ` Douglas Gilbert
2004-08-26 17:20 ` Proposal for fixing READ_CAPACITY Alan Stern
2004-08-23 15:10 ` Incorrect response to SK/ASC/ASCQ = x 02/04/01 (becoming ready) Luben Tuikov
2004-08-23 16:05 ` Nathan Bryant
2004-08-23 18:29 ` Luben Tuikov
2004-08-24 22:04 ` Brian King
[not found] <1088721250.40e4916212bed@wwws.torque.net>
2004-08-03 19:25 ` PATCH: (as355) Fix test for valid sense data present Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093536566.2326.61.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.