From: Albert Cahalan <albert@users.sf.net>
To: linux-kernel mailing list <linux-kernel@vger.kernel.org>
Cc: rlrevell@joe-job.com, mst@mellanox.co.il
Subject: Re: f_ops flag to speed up compatible ioctls in linux kernel
Date: 01 Sep 2004 11:40:22 -0400 [thread overview]
Message-ID: <1094053222.431.7165.camel@cube> (raw)
Michael S. Tsirkin writes:
> Quoting Lee Revell [snip -- that was excessive]
>> By adding a new ioctl you are adding a new use of
>> the BKL. It has been suggested on dri-devel that
>> this should be fixed. Is this even possible?
>
> I dont know - can the lock be released before the
> call to filp->f_op->ioctl ?
>
> I assume the reason its there is for legacy
> code - existing ioctls may be assuming the BKL
> is taken, but maybe there could be another flag
> in f_ops to let sys_ioctl release the lock before
> doing the call ...
>
> Like this - would that be safe?
Yes. It is proven to work.
next reply other threads:[~2004-09-01 15:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 15:40 Albert Cahalan [this message]
2004-09-01 21:23 ` f_ops flag to speed up compatible ioctls in linux kernel Michael S. Tsirkin
2004-09-01 21:38 ` Lee Revell
2004-09-01 21:43 ` Chris Wright
2004-09-01 21:44 ` Roland Dreier
-- strict thread matches above, loose matches on Subject: below --
2004-12-27 22:22 Michael S. Tsirkin
2004-09-01 15:36 Albert Cahalan
2004-09-01 15:59 ` Roland Dreier
2004-09-01 21:53 ` Michael S. Tsirkin
2004-09-01 22:58 ` Roland Dreier
2004-09-01 23:18 ` Michael S. Tsirkin
2004-09-01 9:50 filia
2004-09-01 9:52 ` Arjan van de Ven
2004-09-01 10:16 ` filia
[not found] ` <4135B9FC.7050602@hist.no>
2004-09-01 13:29 ` Ihar 'Philips' Filipau
2004-09-01 15:28 ` Ihar 'Philips' Filipau
2004-09-02 7:29 ` Helge Hafting
2004-09-01 13:43 ` Olivier Galibert
2004-09-01 7:22 Michael S. Tsirkin
2004-09-01 7:32 ` viro
2004-09-01 7:44 ` Michael S. Tsirkin
2004-09-01 7:47 ` Lee Revell
2004-09-01 8:19 ` Michael S. Tsirkin
2004-09-01 15:55 ` Roland Dreier
2004-09-01 18:02 ` Chris Wright
2004-09-01 18:12 ` Roland Dreier
2004-09-01 18:31 ` viro
2004-09-01 20:54 ` Roland Dreier
[not found] ` <20040901170800.K1924@build.pdx.osdl.net>
[not found] ` <20040901190122.L1924@build.pdx.osdl.net>
2004-09-02 3:46 ` Roland Dreier
2004-09-01 18:06 ` Bill Davidsen
2004-09-01 8:30 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094053222.431.7165.camel@cube \
--to=albert@users.sf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@mellanox.co.il \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.