From: Chris Mason <mason@suse.com>
To: Andrey Savochkin <saw@saw.sw.com.sg>
Cc: Andrea Arcangeli <andrea@suse.de>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: EXT3: problem with copy_from_user inside a transaction
Date: Sat, 04 Sep 2004 03:47:44 -0400 [thread overview]
Message-ID: <1094284064.6301.25.camel@watt.suse.com> (raw)
In-Reply-To: <20040903175728.C1834@castle.nmd.msu.ru>
On Fri, 2004-09-03 at 09:57, Andrey Savochkin wrote:
> > This would mean that all the work is done during the commit_write
> > stage. The trick is that we would have to handle -ENOSPC since we might
> > not know we've run out of room until after the data has been copied from
> > userland.
>
> What is the problem -ENOSPC?
> Do you think about the problem of the page existing before this write, it's
> content overwritten, but the filesystem being unable to commit that write
> because it needs more space?
Exactly. In this case, we've effectively corrupted the page cache.
We've copied data in that isn't (and never will be) reflected on disk.
It isn't a horribly difficult case, we just need to overwrite the data
with zeros, making sure to only overwrite the data corresponding to the
-ENOSPC error.
-chris
next prev parent reply other threads:[~2004-09-04 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 11:05 EXT3: problem with copy_from_user inside a transaction Andrey Savochkin
2004-09-03 12:35 ` Andrea Arcangeli
2004-09-03 12:06 ` Chris Mason
2004-09-03 13:03 ` Andrea Arcangeli
2004-09-03 13:57 ` Andrey Savochkin
2004-09-04 7:47 ` Chris Mason [this message]
2004-09-04 14:33 ` Andrey Savochkin
2004-09-04 20:12 ` Andrey Savochkin
2004-09-07 11:55 ` [RFC][PATCH] " Andrey Savochkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094284064.6301.25.camel@watt.suse.com \
--to=mason@suse.com \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=saw@saw.sw.com.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.