From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] doc: update release note for hash library Date: Fri, 26 Oct 2018 01:07:12 +0200 Message-ID: <10943078.SV4r761JHd@xps> References: <1539206862-306341-1-git-send-email-yipeng1.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, Honnappa Nagarahalli , "Mcnamara, John" , "Gobriel, Sameh" , nd To: "Wang, Yipeng1" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 35A1258EC for ; Fri, 26 Oct 2018 01:07:11 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/10/2018 20:45, Wang, Yipeng1: > > -----Original Message----- > > From: Honnappa Nagarahalli [mailto:Honnappa.Nagarahalli@arm.com] > > > > > > +* **Added extendable bucket feature to hash library (rte_hash).** > > > + > > > + This new =E2=80=9Cextendable bucket=E2=80=9D feature provides 100%= insertion > > > + guarantee to the capacity specified by the user by extending hash > > > + table with extra buckets when needed to accommodate the unlikely > > > + event of intensive hash collisions. In addition, the internal > > > + hashing algorithm was changed to use partial-key hashing to improve > > Do we need to provide the reference to partial-key hashing paper? > >=20 > [Wang, Yipeng] Sorry for the delay, I thought I replied... >=20 > I assumed it should be a 1-2 sentence summary so I did not include the ci= tation. >=20 > @John, do you think it is good to include reference here? The original id= ea is from a paper which > I referenced in the source code comments and commit message. It's really better when release notes are updated in the same patch as the code. I have inserted it in your patches when applying them. I think the citation is not so important in the release notes.