From: James Bottomley <James.Bottomley@SteelEye.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Christoph Hellwig <hch@infradead.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] tmscsim: INQUIRY always only untagged
Date: 06 Sep 2004 10:34:23 -0400 [thread overview]
Message-ID: <1094481264.2149.14.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.60.0409052157540.2062@poirot.grange>
On Sun, 2004-09-05 at 16:19, Guennadi Liakhovetski wrote:
> >> 1) remove the inquiry snooping and believe the flags in struct
> >> scsi_device instead
>
> ...and use tags set up by the block layer...
Well, yes, that too ... it depends how much time anyone has to spend on
this driver.
> >> 2) Don't turn on TCQ until slave_configure()
>
> Well, this alone wouldn't help with this specific problem, exactly because
> INQUIRY can be sent later too. Or would the mid-layer completely disable
> tagging for such a disk?
The bug report claims 2.4 works, so probably there the device itself
will still screw up if another inquiry were sent as part of the tagged
stream, I think (perhaps it doesn't, someone needs to check). However,
turning on TCQ in slave_configure() will mean that the two initial
inquiries are sent untagged, so it will only manifest in 2.6 in the same
circumstances as 2.4.
James
next prev parent reply other threads:[~2004-09-06 14:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 22:41 [PATCH] tmscsim: INQUIRY always only untagged Guennadi Liakhovetski
2004-09-04 13:01 ` Christoph Hellwig
2004-09-04 22:26 ` Guennadi Liakhovetski
2004-09-04 22:38 ` Christoph Hellwig
2004-09-05 14:56 ` Guennadi Liakhovetski
2004-09-05 15:42 ` James Bottomley
2004-09-05 16:31 ` Christoph Hellwig
2004-09-05 20:19 ` Guennadi Liakhovetski
2004-09-06 14:34 ` James Bottomley [this message]
2004-09-05 22:22 ` James Bottomley
2004-09-06 8:50 ` Guennadi Liakhovetski
2004-09-06 9:47 ` Guennadi Liakhovetski
2004-09-06 10:01 ` Christoph Hellwig
2004-09-06 13:17 ` Guennadi Liakhovetski
2004-10-01 21:04 ` Guennadi Liakhovetski
2004-10-01 22:35 ` Christoph Hellwig
2004-10-01 22:46 ` Christoph Hellwig
2004-10-01 23:46 ` Guennadi Liakhovetski
2004-10-02 17:00 ` Guennadi Liakhovetski
2004-10-01 21:00 ` Guennadi Liakhovetski
2004-10-01 22:31 ` Christoph Hellwig
2004-10-01 23:44 ` Guennadi Liakhovetski
2004-09-15 5:30 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1094481264.2149.14.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=g.liakhovetski@gmx.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.