From: Danilo Krummrich <dakr@kernel.org>
To: Joel Fernandes <joelagnelf@nvidia.com>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 5/7] gpu: nova-core: add extra integer conversion functions and traits
Date: Mon, 27 Oct 2025 20:23:05 +0100 [thread overview]
Message-ID: <10945c03-8642-4c19-b0ed-ffb20c075291@kernel.org> (raw)
In-Reply-To: <c94dd17e-0e81-47cc-9482-e8743d3bc68f@nvidia.com>
On 10/27/25 8:09 PM, Joel Fernandes wrote:
> Why not just implement `From` and `Into` for the types missing it then, with
> adequate comments about why such conversions are Ok for the kernel, instead of
> introducing a new trait? This is exactly what `From`/`Into` is for right?
https://doc.rust-lang.org/reference/items/implementations.html#r-items.impl.trait.orphan-rule.intro
next prev parent reply other threads:[~2025-10-27 19:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 12:54 [PATCH v2 0/7] gpu: nova-core: remove use of `as` for integer conversions Alexandre Courbot
2025-10-27 12:54 ` [PATCH v2 1/7] gpu: nova-core: replace `as` with `from` conversions where possible Alexandre Courbot
2025-10-27 12:54 ` [PATCH v2 2/7] gpu: nova-core: vbios: remove unneeded u8 conversions Alexandre Courbot
2025-10-27 17:41 ` Joel Fernandes
2025-10-28 7:22 ` Alexandre Courbot
2025-10-27 12:54 ` [PATCH v2 3/7] gpu: nova-core: vbios: add conversion to u8 for BiosImageType Alexandre Courbot
2025-10-27 17:37 ` Joel Fernandes
2025-10-28 7:23 ` Alexandre Courbot
2025-10-27 12:54 ` [PATCH v2 4/7] gpu: nova-core: use `try_from` instead of `as` for u32 conversions Alexandre Courbot
2025-10-27 12:54 ` [PATCH v2 5/7] gpu: nova-core: add extra integer conversion functions and traits Alexandre Courbot
2025-10-27 19:09 ` Joel Fernandes
2025-10-27 19:11 ` Joel Fernandes
2025-10-27 19:23 ` Danilo Krummrich [this message]
2025-10-27 19:28 ` Danilo Krummrich
2025-10-27 19:37 ` Joel Fernandes
2025-10-28 7:23 ` Alexandre Courbot
2025-10-27 12:54 ` [PATCH v2 6/7] gpu: nova-core: replace use of `as` with functions from `num` Alexandre Courbot
2025-10-27 12:54 ` [PATCH v2 7/7] gpu: nova-core: justify remaining uses of `as` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10945c03-8642-4c19-b0ed-ffb20c075291@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.