All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Peter Buckingham <peter@pantasys.com>
Cc: David S Miller <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] ipconfig accepts any DHCPACK
Date: Tue, 07 Sep 2004 17:12:11 -0700	[thread overview]
Message-ID: <1094602330.3076.2.camel@localhost.localdomain> (raw)
In-Reply-To: <413E39F2.4070708@pantasys.com>

On Tue, 2004-09-07 at 15:45, Peter Buckingham wrote: 
> is this okay?
> +				for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
> +						&& (i < dev->addr_len); i++);
> +				if (i < dev->addr_len)
> +					goto drop_unlock;
> +

I had to read that twice.

How about something like:

	for (i=0;i<dev->addr_len;i++)
		if (dev->dev_addr[i] != b->hw_addr[i])
			goto drop_unlock;

or

	if (memcmp(dev->dev_addr, b->hw_addr, dev->addr_len)!=0)
		goto drop_unlock;

instead?

  parent reply	other threads:[~2004-09-08  0:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-07 21:46 [PATCH 2.6] ipconfig accepts any DHCPACK Peter Buckingham
2004-09-07 22:02 ` David S. Miller
2004-09-07 22:45   ` Peter Buckingham
2004-09-07 22:43     ` David S. Miller
2004-09-08  0:12     ` Joe Perches [this message]
2004-09-08  0:18       ` Peter Buckingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1094602330.3076.2.camel@localhost.localdomain \
    --to=joe@perches.com \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=peter@pantasys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.