From: Paul Fulghum <paulkf@microgate.com>
To: Alan Cox <alan@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: tty drivers take two
Date: 16 Sep 2004 14:38:26 -0500 [thread overview]
Message-ID: <1095363506.2937.9.camel@deimos.microgate.com> (raw)
In-Reply-To: <20040916143057.GA15163@devserv.devel.redhat.com>
Alan:
The N_TTY ldisc global reference leak
is still in tty_io.c release_dev().
This does not currently cause a problem because
N_TTY is never deregistered. It seems
a little ugly to have the N_TTY reference
invalid when all other ldisc references
are maintained. I could see this subtle
difference biting someone in the future
when working with this.
The lines that cause the leak serve no
purpose. There is no reason to assign
N_TTY ldisc to a tty instance that
is then immediately thrown away. The lines
that drop the reference to the current ldisc
are, of course, still needed.
--
Paul Fulghum
paulkf@microgate.com
next prev parent reply other threads:[~2004-09-16 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 14:30 PATCH: tty drivers take two Alan Cox
2004-09-16 15:05 ` Paul Fulghum
2004-09-16 16:45 ` Alan Cox
2004-09-16 17:37 ` Paul Fulghum
2004-09-16 15:33 ` Diego Calleja
2004-09-16 19:38 ` Paul Fulghum [this message]
2004-09-16 20:02 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095363506.2937.9.camel@deimos.microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.