From: "hongxu" <hongxu.jia@eng.windriver.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] classes/spdx-common: Fix patch error for recipes that inherit dos2unix.
Date: Thu, 23 Jan 2025 00:56:47 -0800 [thread overview]
Message-ID: <10954.1737622607458995424@lists.openembedded.org> (raw)
In-Reply-To: <2a14a7e2d97936c5e0f68a8320bddc20dd4005d7.camel@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
Hi RP,
Try to provide to suggestions:
1. Use V2 with DEPENDS changing, and correct do_prepare_recipe_sysroot to add it before do_patch
but I am not sure modify do_prepare_recipe_sysroot will cause any side effect or regression
such as:
--- a/meta/classes-global/staging.bbclass
+++ b/meta/classes-global/staging.bbclass
@@ -649,7 +649,7 @@ do_prepare_recipe_sysroot[deptask] = "do_populate_sysroot"
python do_prepare_recipe_sysroot () {
bb.build.exec_func("extend_recipe_sysroot", d)
}
-addtask do_prepare_recipe_sysroot before do_configure after do_fetch
+addtask do_prepare_recipe_sysroot before do_configure do_patch after do_fetch
If V2 is acceptable, I will send a patch to modify do_prepare_recipe_sysroot later
2. Use V1 as temporary workaround, until we have a better solution and clean them
//Hongxu
[-- Attachment #2: Type: text/html, Size: 1533 bytes --]
next prev parent reply other threads:[~2025-01-23 8:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 4:42 [PATCH] classes/spdx-common: Fix patch error for recipes that inherit dos2unix Hongxu Jia
2025-01-22 13:26 ` [OE-core] " Richard Purdie
2025-01-23 8:03 ` hongxu
2025-01-23 8:18 ` [OE-core] " Richard Purdie
[not found] ` <181D447E5FAF7FB4.25327@lists.openembedded.org>
2025-01-23 8:38 ` Richard Purdie
2025-01-23 8:56 ` hongxu [this message]
2025-01-23 8:25 ` [PATCH v2] dos2unix.bbclass: " Hongxu Jia
2025-01-23 8:38 ` [OE-core] " Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10954.1737622607458995424@lists.openembedded.org \
--to=hongxu.jia@eng.windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.