From: Paul Fulghum <paulkf@microgate.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: James Morris <jmorris@redhat.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: 2.6.9-rc2-mm3
Date: Fri, 24 Sep 2004 15:40:15 -0500 [thread overview]
Message-ID: <1096058415.1981.25.camel@deimos.microgate.com> (raw)
In-Reply-To: <20040924204345.C11325@flint.arm.linux.org.uk>
On Fri, 2004-09-24 at 14:43, Russell King wrote:
> a port supporting only 8 bit data transmission
> must not report in termios that it is set to 7 bit data transmission.
OK, the check should stay.
Side note: the current check has an off by one bug:
if (cbaud < 1 || cbaud + 15 > n_baud_table)
termios->c_flag &= ~CBAUDEX;
else
cbaud += 15;
where cbaud is an index into baud_table array
and n_baud_table is the number of elements
in baud_table. The conditional should be:
if (cbaud < 1 || cbaud + 15 >= n_baud_table)
--
Paul Fulghum
paulkf@microgate.com
next prev parent reply other threads:[~2004-09-24 20:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-24 8:46 2.6.9-rc2-mm3 Andrew Morton
2004-09-24 9:30 ` 2.6.9-rc2-mm3 William Lee Irwin III
2004-09-24 9:42 ` 2.6.9-rc2-mm3 William Lee Irwin III
2004-09-24 10:11 ` 2.6.9-rc2-mm3 William Lee Irwin III
2004-09-24 9:54 ` 2.6.9-rc2-mm3 Nick Piggin
2004-09-24 10:05 ` 2.6.9-rc2-mm3 Michal Rokos
2004-09-24 10:15 ` 2.6.9-rc2-mm3 Nick Piggin
2004-09-24 10:25 ` 2.6.9-rc2-mm3 William Lee Irwin III
2004-09-24 10:36 ` 2.6.9-rc2-mm3 Nick Piggin
2004-09-24 14:59 ` 2.6.9-rc2-mm3 Michal Rokos
2004-09-24 10:49 ` 2.6.9-rc2-mm3 Arjan van de Ven
2004-09-24 15:29 ` 2.6.9-rc2-mm3 James Morris
2004-09-24 16:16 ` 2.6.9-rc2-mm3 James Morris
2004-09-24 18:45 ` 2.6.9-rc2-mm3 (tty deadlock?) James Morris
2004-09-24 18:52 ` 2.6.9-rc2-mm3 Paul Fulghum
2004-09-24 19:15 ` 2.6.9-rc2-mm3 Paul Fulghum
2004-09-24 19:43 ` 2.6.9-rc2-mm3 Russell King
2004-09-24 20:40 ` Paul Fulghum [this message]
2004-09-24 21:11 ` 2.6.9-rc2-mm3 Alan Cox
2004-09-25 1:31 ` 2.6.9-rc2-mm3 William Lee Irwin III
2004-09-25 2:12 ` 2.6.9-rc2-mm3 William Lee Irwin III
2004-09-25 3:25 ` 2.6.9-rc2-mm3 Paul Fulghum
2004-09-25 9:19 ` 2.6.9-rc2-mm3 Russell King
2004-09-25 9:27 ` 2.6.9-rc2-mm3 Xavier Bestel
2004-09-25 13:20 ` 2.6.9-rc2-mm3 Russell King
2004-09-24 17:01 ` 2.6.9-rc2-mm3 - [PATCH] tmpfs xattr fix James Morris
2004-09-24 18:08 ` 2.6.9-rc2-mm3 (compile stats) John Cherry
2004-09-24 22:35 ` 2.6.9-rc2-mm3, e100 oops J.A. Magallon
2004-09-24 22:38 ` 2.6.9-rc2-mm3, irq 11: nobody cared!, Disabling IRQ #11 J.A. Magallon
2004-09-25 12:43 ` 2.6.9-rc2-mm3 William Lee Irwin III
2004-09-25 16:37 ` 2.6.9-rc2-mm3 Jens Axboe
2004-09-25 17:11 ` 2.6.9-rc2-mm3 William Lee Irwin III
2004-09-25 17:22 ` 2.6.9-rc2-mm3 breaks amanda (was: 2.6.9-rc2-mm3) Matthias Andree
2004-09-25 18:37 ` Gene Heskett
2004-09-25 21:30 ` Matthias Andree
2004-09-26 2:05 ` Gene Heskett
2004-09-25 22:01 ` 2.6.9-rc2-mm3 Alexander Nyberg
2004-09-27 16:02 ` 2.6.9-rc2-mm4 (compile stats) John Cherry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096058415.1981.25.camel@deimos.microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.