[Kernel-janitors] Re: [PATCH 2.6.9-rc2 1/16] scsi/53c700: replace

From: James Bottomley <James.Bottomley@SteelEye.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: [PATCH 2.6.9-rc2 1/16] scsi/53c700: replace
Date: Mon, 27 Sep 2004 18:21:31 +0000	[thread overview]
Message-ID: <1096309297.2034.62.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.58.0409161253580.14212@server.home>

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On Mon, 2004-09-27 at 14:11, Nishanth Aravamudan wrote:
> --- 2.6.9-rc2-vanilla/drivers/scsi/53c700.c	2004-09-13 17:15:58.000000000 -0700
> +++ 2.6.9-rc2/drivers/scsi/53c700.c	2004-09-14 09:10:24.000000000 -0700
> @@ -1961,7 +1961,7 @@ NCR_700_bus_reset(struct scsi_cmnd * SCp
>  	 * reset via sg or something */
>  	while(hostdata->eh_complete != NULL) {
>  		spin_unlock_irq(SCp->device->host->host_lock);
> -		schedule_timeout(HZ/10);
> +		msleep_interruptible(100);
>  		spin_lock_irq(SCp->device->host->host_lock);
>  	}
>  	hostdata->eh_complete = &complete;

Firstly, could you copy linux-scsi@vger.kernel.org on these, and
secondly there isn't really much point in replacing this, is there?  The
only thing msleep_interruptible() would add is making sure that we slept
for the full time.  However, the code really doesn't care.  All it's
doing is relinquishing the processor for a short period while it waits
for the host eh_complete semaphore to become available.

James

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors