From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Bagalkote, Sreenivas" <sreenib@lsil.com>
Cc: "Mukker, Atul" <Atulm@lsil.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
"'bunk@fs.tum.de'" <bunk@fs.tum.de>,
'Andrew Morton' <akpm@osdl.org>,
"'Matt_Domsch@dell.com'" <Matt_Domsch@dell.com>,
"Ju, Seokmann" <sju@lsil.com>
Subject: RE: [PATCH]: megaraid 2.20.4: Fixes a data corruption bug
Date: 01 Oct 2004 16:58:07 -0400 [thread overview]
Message-ID: <1096664298.1766.103.camel@mulgrave> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E570230C985@exa-atlanta>
On Fri, 2004-10-01 at 16:08, Bagalkote, Sreenivas wrote:
> The submitted previous version of megaraid (2.20.3.1) had
> register_ioctl32_conversion & unregister_ioctl32_conversion
> defined to empty statements if CONFIG_COMPAT was _not_
> defined.
I know that. However, when the empty statements were added to
ioctl32.h, those had to be taken out of the megaraid driver. That's
this patch in the scsi-misc-2.6 tree:
[PATCH] megaraid warning fix
The ioctl32 conversion registration stubs are in ioctl32.h now.
Signed-off-by: Andrew Morton <akpm@osdl.org>
> But I think the preferred way was to have the occurances of
> (un)register_ioctl32_conversion in the code surrounded by
> #ifdef CONFIG_COMPAT ... #endif directly. In the kernel source
> only register_ioctl32_conversion has these #ifdef .. #endif. The
> unregister_ioctl32_conversion doesn't.
The current preferred way is to use the empty definitions in
linux/ioctl32.h which means there's no necessity for adding the #ifdef
CONFIG_COMPAT. The correct thing is to remove the #ifdef CONFIG_COMPAT
from around the register_ioctl32... part.
James
next prev parent reply other threads:[~2004-10-01 20:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-01 20:08 [PATCH]: megaraid 2.20.4: Fixes a data corruption bug Bagalkote, Sreenivas
2004-10-01 20:24 ` James Bottomley
2004-10-01 20:58 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-06 15:23 Bagalkote, Sreenivas
2004-10-05 19:15 Bagalkote, Sreenivas
2004-10-05 19:27 ` James Bottomley
2004-10-01 22:52 Bagalkote, Sreenivas
2004-10-01 23:09 ` James Bottomley
2004-10-01 21:39 Bagalkote, Sreenivas
2004-10-01 20:32 Bagalkote, Sreenivas
2004-10-01 20:43 ` James Bottomley
2004-09-30 16:19 Mukker, Atul
2004-09-29 21:28 Mukker, Atul
2004-09-30 3:16 ` James Bottomley
2004-09-29 1:31 Bagalkote, Sreenivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096664298.1766.103.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=Atulm@lsil.com \
--cc=Matt_Domsch@dell.com \
--cc=akpm@osdl.org \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sju@lsil.com \
--cc=sreenib@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.