From: James Bottomley <James.Bottomley@SteelEye.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mark Lord <lkml@rtr.ca>, Jeff Garzik <jgarzik@pobox.com>,
Mark Lord <lsml@rtr.ca>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3
Date: 08 Oct 2004 08:19:38 -0500 [thread overview]
Message-ID: <1097241583.2412.15.camel@mulgrave> (raw)
In-Reply-To: <20041007221537.A17712@infradead.org>
On Thu, 2004-10-07 at 16:15, Christoph Hellwig wrote:
> - please use the kernel/kthread.c interface for your kernel thread
Actually, the driver has no need for a thread at all. Since you're
simply using it to fire hotplug events, use schedule_work instead.
I also noticed the following in a lightening review:
- Kill these constructs:
+ /* scsi_done expects to be called while locked */
+ if (!in_interrupt())
+ spin_lock_irqsave(uhba->lock, flags);
scsi_done() doesn't require a lock
- Your emulated commands assume they're non-sg and issued through the
kernel (i.e. you don't kmap and you don't do SG). This will blow up on
the first inquiry submitted via SG_IO for instance.
I'm sure there are others, but I don't have time to do a thorough review
at the moment.
James
next prev parent reply other threads:[~2004-10-08 13:19 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 19:11 [PATCH] QStor SATA/RAID driver for 2.6.9-rc3 Mark Lord
2004-10-07 13:42 ` Mark Lord
2004-10-07 14:07 ` Christoph Hellwig
2004-10-07 15:35 ` Mark Lord
2004-10-07 15:50 ` Jeff Garzik
2004-10-07 20:17 ` Mark Lord
2004-10-07 20:30 ` Jeff Garzik
2004-10-07 20:34 ` Mark Lord
2004-10-07 20:46 ` Jeff Garzik
2004-10-07 20:54 ` Mark Lord
2004-10-07 21:15 ` Christoph Hellwig
2004-10-07 22:03 ` Mark Lord
2004-10-20 15:44 ` Christoph Hellwig
2004-10-07 23:39 ` PATCH] " Mark Lord
2004-10-13 18:56 ` [PATCH] QStor SATA/RAID driver for 2.6.9-rc4 Mark Lord
2004-10-08 13:19 ` James Bottomley [this message]
2004-10-08 15:15 ` [PATCH] QStor SATA/RAID driver for 2.6.9-rc3 Mark Lord
2004-10-08 15:27 ` James Bottomley
2004-10-08 15:34 ` Mark Lord
2004-10-08 15:38 ` Jeff Garzik
2004-10-08 16:01 ` James Bottomley
2004-10-12 17:00 ` Mark Lord
2004-10-12 17:05 ` Jeff Garzik
2004-10-12 17:09 ` James Bottomley
2004-10-12 17:31 ` Jeff Garzik
2004-10-08 15:38 ` Mark Lord
2004-10-08 15:47 ` James Bottomley
2004-10-08 15:49 ` Jeff Garzik
2004-10-12 16:59 ` Mark Lord
2004-10-12 17:03 ` Jeff Garzik
2004-10-12 17:14 ` Mark Lord
2004-10-12 17:19 ` Jeff Garzik
2004-10-12 17:23 ` Jeff Garzik
2004-10-12 17:17 ` James Bottomley
2004-10-12 17:22 ` Mark Lord
2004-10-12 17:30 ` James Bottomley
2004-10-12 17:33 ` Mark Lord
2004-10-12 17:42 ` Jeff Garzik
2004-10-12 17:51 ` Mark Lord
2004-10-12 18:12 ` James Bottomley
2004-10-12 18:36 ` Mark Lord
2004-10-12 18:25 ` driver hacking tips (was Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3) Jeff Garzik
2004-10-12 19:18 ` Mark Lord
2004-10-12 19:40 ` Jeff Garzik
2004-10-12 17:34 ` [PATCH] QStor SATA/RAID driver for 2.6.9-rc3 Jeff Garzik
2004-10-07 20:31 ` Christoph Hellwig
2004-10-07 20:35 ` Jeff Garzik
2004-10-07 21:16 ` Mark Lord
2004-10-07 21:44 ` Jeff Garzik
2004-10-07 21:45 ` Jeff Garzik
2004-10-13 20:04 ` Jeff Garzik
2004-10-13 22:16 ` Mark Lord
2004-10-13 22:41 ` Jeff Garzik
2004-10-13 23:24 ` Mark Lord
2004-10-13 23:39 ` Jeff Garzik
2004-10-14 16:30 ` Mark Lord
2004-10-14 16:37 ` Mark Lord
2004-10-14 16:52 ` [PATCH] Export ata_scsi_simulate() for use by non-libata drivers Mark Lord
2004-10-14 17:04 ` Jeff Garzik
2004-10-14 18:44 ` Mark Lord
2004-10-15 5:04 ` Jeff Garzik
2004-10-15 13:25 ` John W. Linville
2004-10-15 14:59 ` Randy.Dunlap
2004-10-15 15:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097241583.2412.15.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkml@rtr.ca \
--cc=lsml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.