From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Daniel Drake <dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Cc: Luming Yu <luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
ACPI Developers
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: Early init patch breaks Dell laptops
Date: 10 Oct 2004 04:44:43 -0400 [thread overview]
Message-ID: <1097397880.16792.23.camel@d845pe> (raw)
In-Reply-To: <416822C3.1040503-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 76 bytes --]
Let me know if this doesn't address all of the regressions.
thanks,
-Len
[-- Attachment #2: lapic.patch --]
[-- Type: text/plain, Size: 836 bytes --]
===== arch/i386/kernel/apic.c 1.60 vs 1.61 =====
--- 1.60/arch/i386/kernel/apic.c 2004-10-06 21:10:37 -04:00
+++ 1.61/arch/i386/kernel/apic.c 2004-10-10 04:12:38 -04:00
@@ -690,22 +690,8 @@
goto no_apic;
}
- if (!cpu_has_apic) {
- /*
- * Some BIOSes disable the local APIC in the
- * APIC_BASE MSR. This can only be done in
- * software for Intel P6 and AMD K7 (Model > 1).
- */
- rdmsr(MSR_IA32_APICBASE, l, h);
- if (!(l & MSR_IA32_APICBASE_ENABLE)) {
- apic_printk(APIC_VERBOSE, "Local APIC disabled "
- "by BIOS -- reenabling.\n");
- l &= ~MSR_IA32_APICBASE_BASE;
- l |= MSR_IA32_APICBASE_ENABLE | APIC_DEFAULT_PHYS_BASE;
- wrmsr(MSR_IA32_APICBASE, l, h);
- enabled_via_apicbase = 1;
- }
- }
+ if (!cpu_has_apic)
+ goto no_apic;
/*
* The APIC feature bit should now be enabled
* in `cpuid'
next prev parent reply other threads:[~2004-10-10 8:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-09 15:26 Early init patch breaks Dell laptops Yu, Luming
2004-10-09 17:41 ` Daniel Drake
[not found] ` <416822C3.1040503-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2004-10-10 8:44 ` Len Brown [this message]
2004-10-10 18:42 ` Daniel Drake
-- strict thread matches above, loose matches on Subject: below --
2004-10-10 9:00 Li, Shaohua
[not found] ` <16A54BF5D6E14E4D916CE26C9AD30575457610-4yWAQGcml66iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2004-10-10 9:08 ` Len Brown
2004-10-10 7:13 Brown, Len
2004-10-09 14:08 Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097397880.16792.23.camel@d845pe \
--to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
--cc=luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.