From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mikael Pettersson <mikpe@user.it.uu.se>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: 745x coherency fix for 2.4?
Date: Sat, 16 Oct 2004 21:23:21 +1000 [thread overview]
Message-ID: <1097925801.8965.42.camel@gaston> (raw)
In-Reply-To: <16752.64288.975262.790788@alkaid.it.uu.se>
>
> -#ifdef CONFIG_SMP
> - if ((flags & _PAGE_NO_CACHE) == 0)
> + if (((flags & _PAGE_NO_CACHE) == 0) &&
> + (cur_cpu_spec[0]->cpu_features & CPU_FTR_NEED_COHERENT))
> flags |= _PAGE_COHERENT;
> -#endif
Wouldn't your patch result in _not_ setting _PAGE_COHERENT on non-broken
CPUs when CONFIG_SMP is set ?
Ben.
next prev parent reply other threads:[~2004-10-16 11:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-16 10:42 745x coherency fix for 2.4? Mikael Pettersson
2004-10-16 11:23 ` Benjamin Herrenschmidt [this message]
2004-10-16 11:35 ` Mikael Pettersson
2004-10-16 12:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097925801.8965.42.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikpe@user.it.uu.se \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.