All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: James.Smart@Emulex.Com
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [Patch] Fix Suspend I/O block/unblock patch
Date: 16 Oct 2004 11:39:27 -0500	[thread overview]
Message-ID: <1097944773.2283.123.camel@mulgrave> (raw)
In-Reply-To: <0B1E13B586976742A7599D71A6AC733C02F20B@xbl3.ma.emulex.com>

On Thu, 2004-10-14 at 09:31, James.Smart@Emulex.Com wrote:
> In further testing of the fc block/unblock patch, the recommendation to use device_for_each_child() instead of shost_for_each_device() in the target functions was not a good one. The calling sequences on the unblock path, which may eventually block, are not good for device_for_each_child(), which takes and holds a semaphore.

Could you give an example of this problem?  If there's a demonstrable
issue with device_for_each_child(), we can probably persuade Greg to
alter it.

James



  reply	other threads:[~2004-10-16 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-14 14:31 [Patch] Fix Suspend I/O block/unblock patch James.Smart
2004-10-16 16:39 ` James Bottomley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-10-16 21:59 James.Smart
2004-10-16 23:13 ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1097944773.2283.123.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=James.Smart@Emulex.Com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.