From: John McCutchan <ttb@tentacle.dhs.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Robert Love <rml@novell.com>,
v13@priest.com, linux-kernel@vger.kernel.org,
gamin-list@gnome.org, viro@parcelfarce.linux.theplanet.co.uk,
akpm@osdl.org, bkonrath@redhat.com, greg@kroah.com
Subject: Re: [RFC][PATCH] inotify 0.14
Date: Sun, 17 Oct 2004 22:20:43 -0400 [thread overview]
Message-ID: <1098066043.16758.4.camel@vertex> (raw)
In-Reply-To: <20041018112807.3a7edbf7.sfr@canb.auug.org.au>
On Sun, 2004-10-17 at 21:28, Stephen Rothwell wrote:
> On Sun, 17 Oct 2004 19:52:09 -0400 Robert Love <rml@novell.com> wrote:
> >
> > It should make dnotify a configuration option, controlled via
> > CONFIG_DNOTIFY.
>
> But you have removed the sysctl that allows enabling and disabling of
> dnotify at run time. And you create setattr_mask_dnotify for which I can
> find no caller. And make gratuitous changes to the current dnotify code.
> (I point this last out as it just increases the size of the patch for no
> purpose.)
There may be bugs with how dnotify was made optional. I will accept a
patch that fixes this :)
It is debatable whether or not the inotify patch should carry this
dnotify config patch as well. I don't see it being that large of a
burden on maintaining or using the patch that includes the dnotify
config changes.
John
next prev parent reply other threads:[~2004-10-18 2:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-15 2:44 [RFC][PATCH] inotify 0.14 John McCutchan
2004-10-17 23:46 ` V13
2004-10-17 23:52 ` Robert Love
2004-10-18 1:28 ` Stephen Rothwell
2004-10-18 1:32 ` Stephen Rothwell
2004-10-18 2:17 ` John McCutchan
2004-10-18 2:20 ` John McCutchan [this message]
2004-10-18 7:00 ` Stephen Rothwell
2004-10-18 16:48 ` Robert Love
2004-10-17 23:52 ` John McCutchan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098066043.16758.4.camel@vertex \
--to=ttb@tentacle.dhs.org \
--cc=akpm@osdl.org \
--cc=bkonrath@redhat.com \
--cc=gamin-list@gnome.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@novell.com \
--cc=sfr@canb.auug.org.au \
--cc=v13@priest.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.