From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] I2C update for 2.6.9
Date: Tue, 19 Oct 2004 17:18:23 -0700 [thread overview]
Message-ID: <10982315034183@kroah.com> (raw)
In-Reply-To: <10982315033970@kroah.com>
ChangeSet 1.1832.73.2, 2004/09/08 12:34:06-07:00, castet.matthieu@free.fr
[PATCH] use of MODULE_DEVICE_TABLE in i2c busses driver
hello,
since you say your are interested of using MODULE_DEVICE_TABLE in
http://bugzilla.kernel.org/show_bug.cgi?id=3091 I did a patch (attach).
Also I notice that some pci_device_id are marked __devinitdata that seem a bug
if I read Linux 2.6.0-test3 changelog.
To find them do a "grep pci_device_id /usr/src/linux/drivers/i2c/busses/* |
grep __devinitdata"
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/i2c/busses/i2c-ali1535.c | 2 ++
drivers/i2c/busses/i2c-ali1563.c | 2 ++
drivers/i2c/busses/i2c-ali15x3.c | 2 ++
drivers/i2c/busses/i2c-amd756.c | 2 ++
drivers/i2c/busses/i2c-amd8111.c | 2 ++
drivers/i2c/busses/i2c-hydra.c | 2 ++
drivers/i2c/busses/i2c-i801.c | 2 ++
drivers/i2c/busses/i2c-i810.c | 2 ++
drivers/i2c/busses/i2c-nforce2.c | 3 +++
drivers/i2c/busses/i2c-piix4.c | 2 ++
drivers/i2c/busses/i2c-prosavage.c | 2 ++
drivers/i2c/busses/i2c-savage4.c | 2 ++
drivers/i2c/busses/i2c-sis5595.c | 2 ++
drivers/i2c/busses/i2c-sis630.c | 2 ++
drivers/i2c/busses/i2c-sis96x.c | 2 ++
drivers/i2c/busses/i2c-via.c | 2 ++
drivers/i2c/busses/i2c-viapro.c | 2 ++
drivers/i2c/busses/i2c-voodoo3.c | 2 ++
18 files changed, 37 insertions(+)
diff -Nru a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
--- a/drivers/i2c/busses/i2c-ali1535.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-ali1535.c 2004-10-19 16:55:57 -07:00
@@ -496,6 +496,8 @@
{ },
};
+MODULE_DEVICE_TABLE (pci, ali1535_ids);
+
static int __devinit ali1535_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
if (ali1535_setup(dev)) {
diff -Nru a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c
--- a/drivers/i2c/busses/i2c-ali1563.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-ali1563.c 2004-10-19 16:55:57 -07:00
@@ -394,6 +394,8 @@
{},
};
+MODULE_DEVICE_TABLE (pci, ali1563_id_table);
+
static struct pci_driver ali1563_pci_driver = {
.name = "ali1563_i2c",
.id_table = ali1563_id_table,
diff -Nru a/drivers/i2c/busses/i2c-ali15x3.c b/drivers/i2c/busses/i2c-ali15x3.c
--- a/drivers/i2c/busses/i2c-ali15x3.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-ali15x3.c 2004-10-19 16:55:57 -07:00
@@ -486,6 +486,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, ali15x3_ids);
+
static int __devinit ali15x3_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
if (ali15x3_setup(dev)) {
diff -Nru a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c
--- a/drivers/i2c/busses/i2c-amd756.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-amd756.c 2004-10-19 16:55:57 -07:00
@@ -320,6 +320,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, amd756_ids);
+
static int __devinit amd756_probe(struct pci_dev *pdev,
const struct pci_device_id *id)
{
diff -Nru a/drivers/i2c/busses/i2c-amd8111.c b/drivers/i2c/busses/i2c-amd8111.c
--- a/drivers/i2c/busses/i2c-amd8111.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-amd8111.c 2004-10-19 16:55:57 -07:00
@@ -336,6 +336,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, amd8111_ids);
+
static int __devinit amd8111_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
struct amd_smbus *smbus;
diff -Nru a/drivers/i2c/busses/i2c-hydra.c b/drivers/i2c/busses/i2c-hydra.c
--- a/drivers/i2c/busses/i2c-hydra.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-hydra.c 2004-10-19 16:55:57 -07:00
@@ -120,6 +120,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, hydra_ids);
+
static int __devinit hydra_probe(struct pci_dev *dev,
const struct pci_device_id *id)
{
diff -Nru a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
--- a/drivers/i2c/busses/i2c-i801.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-i801.c 2004-10-19 16:55:57 -07:00
@@ -599,6 +599,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, i801_ids);
+
static int __devinit i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
diff -Nru a/drivers/i2c/busses/i2c-i810.c b/drivers/i2c/busses/i2c-i810.c
--- a/drivers/i2c/busses/i2c-i810.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-i810.c 2004-10-19 16:55:57 -07:00
@@ -201,6 +201,8 @@
{ 0, },
};
+MODULE_DEVICE_TABLE (pci, i810_ids);
+
static int __devinit i810_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
int retval;
diff -Nru a/drivers/i2c/busses/i2c-nforce2.c b/drivers/i2c/busses/i2c-nforce2.c
--- a/drivers/i2c/busses/i2c-nforce2.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-nforce2.c 2004-10-19 16:55:57 -07:00
@@ -298,6 +298,9 @@
};
+MODULE_DEVICE_TABLE (pci, nforce2_ids);
+
+
static int __devinit nforce2_probe_smb (struct pci_dev *dev, int reg,
struct nforce2_smbus *smbus, char *name)
{
diff -Nru a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
--- a/drivers/i2c/busses/i2c-piix4.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-piix4.c 2004-10-19 16:55:57 -07:00
@@ -459,6 +459,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, piix4_ids);
+
static int __devinit piix4_probe(struct pci_dev *dev,
const struct pci_device_id *id)
{
diff -Nru a/drivers/i2c/busses/i2c-prosavage.c b/drivers/i2c/busses/i2c-prosavage.c
--- a/drivers/i2c/busses/i2c-prosavage.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-prosavage.c 2004-10-19 16:55:57 -07:00
@@ -313,6 +313,8 @@
{ 0, },
};
+MODULE_DEVICE_TABLE (pci, prosavage_pci_tbl);
+
static struct pci_driver prosavage_driver = {
.name = "prosavage_smbus",
.id_table = prosavage_pci_tbl,
diff -Nru a/drivers/i2c/busses/i2c-savage4.c b/drivers/i2c/busses/i2c-savage4.c
--- a/drivers/i2c/busses/i2c-savage4.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-savage4.c 2004-10-19 16:55:57 -07:00
@@ -157,6 +157,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, savage4_ids);
+
static int __devinit savage4_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
int retval;
diff -Nru a/drivers/i2c/busses/i2c-sis5595.c b/drivers/i2c/busses/i2c-sis5595.c
--- a/drivers/i2c/busses/i2c-sis5595.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-sis5595.c 2004-10-19 16:55:57 -07:00
@@ -371,6 +371,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, sis5595_ids);
+
static int __devinit sis5595_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
if (sis5595_setup(dev)) {
diff -Nru a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c
--- a/drivers/i2c/busses/i2c-sis630.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-sis630.c 2004-10-19 16:55:57 -07:00
@@ -468,6 +468,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, sis630_ids);
+
static int __devinit sis630_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
if (sis630_setup(dev)) {
diff -Nru a/drivers/i2c/busses/i2c-sis96x.c b/drivers/i2c/busses/i2c-sis96x.c
--- a/drivers/i2c/busses/i2c-sis96x.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-sis96x.c 2004-10-19 16:55:57 -07:00
@@ -278,6 +278,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, sis96x_ids);
+
static int __devinit sis96x_probe(struct pci_dev *dev,
const struct pci_device_id *id)
{
diff -Nru a/drivers/i2c/busses/i2c-via.c b/drivers/i2c/busses/i2c-via.c
--- a/drivers/i2c/busses/i2c-via.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-via.c 2004-10-19 16:55:57 -07:00
@@ -99,6 +99,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, vt586b_ids);
+
static int __devinit vt586b_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
u16 base;
diff -Nru a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c
--- a/drivers/i2c/busses/i2c-viapro.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-viapro.c 2004-10-19 16:55:57 -07:00
@@ -454,6 +454,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, vt596_ids);
+
static struct pci_driver vt596_driver = {
.name = "vt596_smbus",
.id_table = vt596_ids,
diff -Nru a/drivers/i2c/busses/i2c-voodoo3.c b/drivers/i2c/busses/i2c-voodoo3.c
--- a/drivers/i2c/busses/i2c-voodoo3.c 2004-10-19 16:55:57 -07:00
+++ b/drivers/i2c/busses/i2c-voodoo3.c 2004-10-19 16:55:57 -07:00
@@ -195,6 +195,8 @@
{ 0, }
};
+MODULE_DEVICE_TABLE (pci, voodoo3_ids);
+
static int __devinit voodoo3_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
int retval;
next prev parent reply other threads:[~2004-10-20 0:53 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 0:16 [BK PATCH] I2C update for 2.6.9 Greg KH
2005-05-19 6:25 ` Greg KH
2004-10-20 0:18 ` [PATCH] " Greg KH
2004-10-20 0:18 ` Greg KH [this message]
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 0:18 ` Greg KH
2004-10-20 5:21 ` Eugene Surovegin
2005-05-19 6:25 ` Eugene Surovegin
2004-10-20 6:26 ` [PATCH] fix recently introduced race in IBM PPC4xx I2C driver Eugene Surovegin
2005-05-19 6:25 ` Eugene Surovegin
2004-10-22 19:55 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-10-25 18:29 ` [PATCH] I2C update for 2.6.9 Bill Davidsen
2005-05-19 6:25 ` Bill Davidsen
2004-10-25 20:54 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-10-26 21:03 ` Bill Davidsen
2005-05-19 6:25 ` Bill Davidsen
2004-10-20 15:57 ` [BK PATCH] " Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-10-20 16:40 ` Lee Revell
2005-05-19 6:25 ` Lee Revell
2004-10-22 21:34 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10982315034183@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.