From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Mark Lord <lsml@rtr.ca>,
linux-scsi@vger.kernel.org, Jens Axboe <axboe@suse.de>
Subject: Re: [PATCH] Re: libata: BLKFLSBUF ioctl broken
Date: Fri, 22 Oct 2004 17:14:29 +0100 [thread overview]
Message-ID: <1098461668.19463.22.camel@localhost.localdomain> (raw)
In-Reply-To: <41793E68.6010000@pobox.com>
On Gwe, 2004-10-22 at 18:07, Jeff Garzik wrote:
> Ok, I think I see what's going on. Can you get your users to try the
> attached patch?
This patch is definitely wrong.
> Maybe libata should be returning ENOTTY, but that's _quite_ nonsensical
> considering that EOPNOTSUPP describes the error much better (and is a
> standard I-don't-support-that-operation return code in tons of other
> Linux ioctl-handling code).
libata should be returning -ENOTTY "I don't know what you are talking
about", and the core block layer will then fallback and do generic
handling
-EOPNOTSUPP is saying "I do know what is going on but its broken so
fail it totally".
next prev parent reply other threads:[~2004-10-22 17:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 21:04 libata: BLKFLSBUF ioctl broken Mark Lord
2004-10-22 4:04 ` Jeff Garzik
2004-10-22 14:20 ` Mark Lord
2004-10-22 17:07 ` [PATCH] " Jeff Garzik
2004-10-22 16:14 ` Alan Cox [this message]
2004-10-22 17:20 ` Jeff Garzik
2004-10-22 17:40 ` Mark Lord
2004-10-22 18:16 ` Alan Cox
2004-10-22 19:42 ` Doug Maxey
2004-10-22 20:31 ` Alan Cox
2004-10-25 20:24 ` Bryan Henderson
2004-10-22 20:58 ` Bryan Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098461668.19463.22.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lsml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.