All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Lorenz <tobias.lorenz@gmx.net>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH 2.6.9-libata1-dev1] libata-scsi: hdparm support
Date: Sat, 23 Oct 2004 23:59:12 +0200	[thread overview]
Message-ID: <1098568752.8926.16.camel@server.lorenz.priv> (raw)
In-Reply-To: <58cb370e04102305363da96ebd@mail.gmail.com>

Hi,

Bartlomiej Zolnierkiewicz wrote:
> dev->id
> 
> HDIO_GET_IDENTITY (as used by 'hdparm -i') should return _original_
> drive ID (dev->id should be returned) so currently used mode may not
> be reported correctly.

The used mode isn't reported yet. Only cylinders, sectors, heads, model
and firmware version are supported by now.

dev is of type ata_device, so dev->id is 
u16                     id[ATA_ID_WORDS]; /* IDENTIFY xxx DEVICE data */

Where in dev->id are the model and revision strings encoded ? Here is a comparison:
ata1: dev 0 cfg 49:2f00 82:74eb 83:4bea 84:4000 85:7469 86:0802 87:4003 88:203f
ata_dump_id: 49==0x2f00 53==0x0007 63==0x0007 64==0x0003 75==0x001f
ata_dump_id: 80==0x003c 81==0x0015 82==0x74eb 83==0x4bea 84==0x4000
ata_dump_id: 88==0x203f 93==0x600b

ata_scsiop_inq_std: ENTER
  Vendor: ATA Model: IC35L060AVER07-0 Rev: 1.01
  Type: Direct-Access ANSI SCSI revision: 05 

> 'hdparm -I' should be already supported by current libata-dev tree.
hdparm -I needs implementations for the HDIO_GET_MULTCOUNT and
HDIO_GET_IDENTITY commands in ata_scsi_ioctl to report informations.
Both were not implemented.

Toby



  reply	other threads:[~2004-10-23 21:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-22 23:20 [PATCH 2.6.9-libata1-dev1] libata-scsi: hdparm support Tobias Lorenz
2004-10-23 12:36 ` Bartlomiej Zolnierkiewicz
2004-10-23 21:59   ` Tobias Lorenz [this message]
2004-10-30 12:43 ` Jeff Garzik
2004-10-30 14:58   ` Tobias Lorenz
2004-10-30 15:27     ` Jeff Garzik
2004-11-02 21:51       ` Bartlomiej Zolnierkiewicz
2004-11-04 16:55         ` Tobias Lorenz
2004-11-04 19:50           ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1098568752.8926.16.camel@server.lorenz.priv \
    --to=tobias.lorenz@gmx.net \
    --cc=bzolnier@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.