From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: maximilian attems <janitor@sternwelten.at>,
Nishanth Aravamudan <nacc@us.ibm.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: RE: [patch 08/10] scsi/dpt_i2o: replace schedule_timeout()withmsleep_interruptible()
Date: 25 Oct 2004 10:19:01 -0400 [thread overview]
Message-ID: <1098713947.2023.13.camel@mulgrave> (raw)
In-Reply-To: <60807403EABEB443939A5A7AA8A7458B40B9B3@otce2k01.adaptec.com>
On Mon, 2004-10-25 at 07:30, Salyzyn, Mark wrote:
> Not quite ... The value of 0 is meant to trigger never timing out on the
> request (#define FOREVER (0) in dpti.h). The code change you have will
> mean that the code will immediately timeout, not the intent.
>
> There is a wakeup to the thread issued by the interrupt via a WAIT
> QUEUE, if the sequence of TASK_INTERRUPTIBLE/schedule() did not work, it
> would not explain the successful operation of the driver during
> initialization time.
So this is basically an open coded interruptible_sleep_on_timeout()?
Why not replace it with this? (although this will excite the janitors
since sleep_on is deprecated in all its forms).
Also, if you define your FOREVER to be MAX_SCHEDULE_TIMEOUT, you don't
need to special case this.
James
next prev parent reply other threads:[~2004-10-25 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-25 11:30 [patch 08/10] scsi/dpt_i2o: replace schedule_timeout()withmsleep_interruptible() Salyzyn, Mark
2004-10-25 14:19 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-21 14:11 Salyzyn, Mark
2004-10-22 23:22 ` Nishanth Aravamudan
2004-10-24 14:03 ` maximilian attems
2004-10-24 14:39 ` James Bottomley
2004-10-21 13:17 [patch 08/10] scsi/dpt_i2o: replace schedule_timeout() withmsleep_interruptible() Salyzyn, Mark
2004-10-21 13:47 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098713947.2023.13.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=janitor@sternwelten.at \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.