From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:ee0a:0:0:0:0:0 with SMTP id g10csp662419lfb; Wed, 11 Nov 2020 10:33:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJxB/6IJvNRS+zrlB1gCyQkWoHkFJvta0tr05R0IvZQ7xO49ITF7tVnPJ/+fFgVWvXSSVoE4 X-Received: by 2002:a25:718a:: with SMTP id m132mr32620983ybc.169.1605119592266; Wed, 11 Nov 2020 10:33:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605119592; cv=none; d=google.com; s=arc-20160816; b=rXdHD//duL1f/nSbOOm/4FGqjUUDb3ZE1Ybkak3JgGIj0ix7fAFUrOmFOh95jHc7Lm TxQwo7d7oSNnd6bS0/7ojk2ijj8Rb8XnQDS07eorHcUw63BD5JWTSAZk0Bz5/FshsaBj 5/eBPwnz7c229xQjGu99mExMUc6sZO+BF+sC0Km4zismZ10u0B2+2iR1Io4vuDwu1Fpz XkeTvEyftbl0lm4dt8ZuR3hqk3oW4JBrq8iE9INkMB0yNMv75EZ5T2F51mGVZ5Fc4iHr czbRE+/Z69mFcnSpheyU0MUXyfQKEszWA0D+oAQajTOIlcJI5PVo06qmITRvgdsPRJ52 pa0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :thread-index:thread-topic:mime-version:subject:references :in-reply-to:message-id:to:from:date:dkim-signature; bh=aQciIk3KJ/LNoZlpArgYBI4Qpqtuphnkh6mMzTvU0Q8=; b=1Crcq3JLoxfCf3C3LMN5pXgnwi4Sv4dZDE77KlZT0G8r2XzsubWF316gSN3acoe5vD abof0LHYHRgrLxWN2kQT14el3sprnzFwE66KvCZHY4/Cy76oXFtnl3UFik9RE4s8PBCI U/RYSeGJo9JZtwjiNiHc0YTGBMU1RFFrXTPDhh773S0t0wvh9W0KOvCJSYmlTngT7KNa 8Ruz7KV1XeR6GHGM6LlVRJGIzsBohGJL5G1yJGobVQvf+NaGtKS0Vo0lsJNsfFT8v91z 0ZH8oWxnIvbf4BreKxz4NmBjZGuKMjv8vqBq9oe2wfoubE/8OJ/zwp3xlUxG+55nDKJC TmrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CgJ11BgV; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c10si2607567ybi.116.2020.11.11.10.33.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Nov 2020 10:33:12 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=CgJ11BgV; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:54296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcuvf-0006RI-Jh for alex.bennee@linaro.org; Wed, 11 Nov 2020 13:33:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcuvX-0006R4-5G for qemu-arm@nongnu.org; Wed, 11 Nov 2020 13:33:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20643) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcuvT-00061d-Oc for qemu-arm@nongnu.org; Wed, 11 Nov 2020 13:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605119578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aQciIk3KJ/LNoZlpArgYBI4Qpqtuphnkh6mMzTvU0Q8=; b=CgJ11BgVhI6yZCCT2dY5MwMqAzuGF1EVfdzRLlVBIU7zmop6q3W4erF7r/pgEV4s+puzhO qAFQPxU3kYMwGDVSM7xCh5gaPHXu6HJJNBP/jC3vAfP1FCW+EXF2yQYx16ZCRWxn5QRfp1 lEmqnlDXnJywYOwNKMScE5xURU4LB28= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-rZ7ZyvhyOH6jYcc6cF8vjg-1; Wed, 11 Nov 2020 13:32:56 -0500 X-MC-Unique: rZ7ZyvhyOH6jYcc6cF8vjg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2EC70106B268; Wed, 11 Nov 2020 18:32:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 257A95C1C4; Wed, 11 Nov 2020 18:32:54 +0000 (UTC) Received: from zmail17.collab.prod.int.phx2.redhat.com (zmail17.collab.prod.int.phx2.redhat.com [10.5.83.19]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D5BA144A43; Wed, 11 Nov 2020 18:32:53 +0000 (UTC) Date: Wed, 11 Nov 2020 13:32:53 -0500 (EST) From: Miroslav Rezanina To: Andrew Jones Message-ID: <1098879863.23006642.1605119573830.JavaMail.zimbra@redhat.com> In-Reply-To: <20201111173932.yjrlkddo6v6msqff@kamzik.brq.redhat.com> References: <20201111143440.112763-1-drjones@redhat.com> <1888391810.22919498.1605107125694.JavaMail.zimbra@redhat.com> <20201111173932.yjrlkddo6v6msqff@kamzik.brq.redhat.com> Subject: Re: [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC MIME-Version: 1.0 X-Originating-IP: [10.40.192.178, 10.4.195.7] Thread-Topic: hw/arm/virt: ARM_VIRT must select ARM_GIC Thread-Index: LFumSa2vd0Zp2n0M6fxWBdJnJl5k1g== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mrezanin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=mrezanin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 01:42:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , QEMU Developers , Paolo Bonzini Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: lwzJVzGCflX7 ----- Original Message ----- > From: "Andrew Jones" > To: "Peter Maydell" > Cc: "Miroslav Rezanina" , "QEMU Developers" , "qemu-arm" > , "Philippe Mathieu-Daud=C3=A9" > Sent: Wednesday, November 11, 2020 6:39:32 PM > Subject: Re: [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC >=20 > On Wed, Nov 11, 2020 at 04:00:25PM +0000, Peter Maydell wrote: > > On Wed, 11 Nov 2020 at 15:05, Miroslav Rezanina > > wrote: > > > > > > ----- Original Message ----- > > > > From: "Andrew Jones" > > > > To: qemu-devel@nongnu.org, qemu-arm@nongnu.org > > > > Cc: "peter maydell" , philmd@redhat.com, > > > > "Miroslav Rezanina" > > > > Sent: Wednesday, November 11, 2020 3:34:40 PM > > > > Subject: [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC > > > > > > > > The removal of the selection of A15MPCORE from ARM_VIRT also > > > > removed what A15MPCORE selects, ARM_GIC. We still need ARM_GIC. > >=20 > > > > > > Problems with missing dependencies solved by this patch. > > > > > > Reviewed-by: Miroslav Rezanina > >=20 > > This is the second of this kind of "missing select" bug I've > > seen recently. I don't suppose there's some kind of testing > > we could add to 'make check' that automatically catches them? > > >=20 > Miroslav is finding them because the RHEL build of QEMU is more selective > than upstream as to what gets pulled in. Effort keeps going into making > upstream more configurable, but it's not quite there yet for RHEL's > purposes. I'm not sure how best to test something like this upstream. > I guess it would require the flexible configuration support we don't yet > have. >=20 We use --without-default-devices and then add only supported devices - this= allow us to find this kind of errors. To prevent them by test we would need compl= ete matrix possible of device configurations (or just usable combinations). Not always= is broken build wrong - it can be caused by unusable configuration. In this case, we have correct dependency - CONFIG_ARM_GIC_KVM requires CONF= IG_KVM and CONFIG_ARM_GIC. In RC1 commit bec3c97e0cf9 (hw/arm/virt: Remove dependency on Cortex-A15 MP= Core peripherals) removed indirect CONFIG_ARM_GIC from CONFIG_ARM_VIRT. So anyone using CONFIG_ARM_GI= C_KVM with CONFIG_ARM_VIRT now gets build error.=20 Question here is: Is okay to use CONFIG_ARM_GIC_KVM with CONFIG_ARM_VIRT wi= thout explicit CONFIG_ARM_GIC? I can imagine both answers: 1) yes - CONFIG_ARM_VIRT implicate presence of CONFIG_ARM_GIC so no need to= add it explicitly 2) no - If you want to use CONFIG_ARM_GIC_KVM you have to always add CONFIG= _ARM_GIC explicitly too I'm little bit confused now - why KConfig uses depends instead of select? I= f using option without dependent one is not possible shouldn't be logical to just get it? Mirek > Thanks, > drew >=20 --=20 Miroslav Rezanina Software Engineer - Virtualization Team Maintainer