From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@elka.pw.edu.pl>
Cc: linux-ide@vger.kernel.org
Subject: Re: PATCH: allow ide-generic users to ask it to capture unknown devices
Date: Sat, 06 Nov 2004 00:52:53 +0000 [thread overview]
Message-ID: <1099702372.5556.95.camel@localhost.localdomain> (raw)
In-Reply-To: <200411060146.05980.bzolnier@elka.pw.edu.pl>
On Sad, 2004-11-06 at 00:46, Bartlomiej Zolnierkiewicz wrote:
> > Because when someone adds an entry they'll break the driver.
>
> Please be specific, what will break?
The entry is currently last. Someone seeing the comment it must be last
is likely to also leave it last in the table and thus the hardcoded 14
would
need to become 15. Making it "0" took away the cause.
> > Correct but they must force it on by hand. It generates a printk to tell
> > the user and so its obvious in any bug reports..
>
> 99% of IDE bugreports don't contain full dmesg...
At the moment it prints it quite early. If I move the printk down I can
change it so that at the point it grabs the hwif (ie right in the IDE
logs)
it says "blah blah grabbing Unknown device (0x1111, 0x2222)"
Would that be preferable ?
prev parent reply other threads:[~2004-11-06 1:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 16:22 PATCH: allow ide-generic users to ask it to capture unknown devices Alan Cox
2004-11-05 21:56 ` Bartlomiej Zolnierkiewicz
2004-11-05 23:27 ` Alan Cox
2004-11-06 0:46 ` Bartlomiej Zolnierkiewicz
2004-11-06 0:52 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099702372.5556.95.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@elka.pw.edu.pl \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.