From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: adaplas@pol.net
Cc: Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb
Date: Tue, 09 Nov 2004 08:52:01 +1100 [thread overview]
Message-ID: <1099950722.10262.166.camel@gaston> (raw)
In-Reply-To: <200411081706.55261.adaplas@hotpop.com>
On Mon, 2004-11-08 at 17:06 +0800, Antonino A. Daplas wrote:
>
> How about this patch? This is almost the original macro in riva_hw.h,
> with the __force annotation.
I don't like it neither. It lacks barriers. the rivafb driver
notoriously lacks barriers, except in a few places where it was so bad
that it actually broke all the time, where we added some. This
originates from the X "nv" driver written by Mark Vojkovich who didn't
want to hear about barriers for perfs reasons I think.
Ben.
next prev parent reply other threads:[~2004-11-08 21:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200411080521.iA85LbG6025914@hera.kernel.org>
2004-11-08 5:57 ` [PATCH] fbdev: Fix IO access in rivafb Benjamin Herrenschmidt
2004-11-08 8:33 ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-11-08 8:33 ` Antonino A. Daplas
2004-11-08 21:50 ` Benjamin Herrenschmidt
2004-11-08 22:18 ` Antonino A. Daplas
2004-11-08 9:06 ` Antonino A. Daplas
2004-11-08 9:06 ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-11-08 9:55 ` Geert Uytterhoeven
2004-11-08 15:21 ` Linus Torvalds
2004-11-08 15:21 ` [Linux-fbdev-devel] " Linus Torvalds
2004-11-08 20:02 ` Antonino A. Daplas
2004-11-08 20:02 ` Antonino A. Daplas
2004-11-08 20:13 ` Linus Torvalds
2004-11-08 22:08 ` Antonino A. Daplas
2004-11-08 22:08 ` Antonino A. Daplas
2004-11-08 22:25 ` Linus Torvalds
2004-11-12 12:51 ` Guido Guenther
2004-11-12 12:51 ` [Linux-fbdev-devel] " Guido Guenther
2004-11-12 16:01 ` Linus Torvalds
2004-11-12 19:18 ` Guido Guenther
2004-11-12 19:18 ` [Linux-fbdev-devel] " Guido Guenther
2004-11-12 19:32 ` Linus Torvalds
2004-11-13 12:57 ` Guido Guenther
2004-11-13 12:57 ` [Linux-fbdev-devel] " Guido Guenther
2004-11-13 1:39 ` Benjamin Herrenschmidt
2004-11-13 1:39 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2004-11-13 11:22 ` Guido Guenther
2004-11-13 11:22 ` [Linux-fbdev-devel] " Guido Guenther
2004-11-13 12:00 ` Antonino A. Daplas
2004-11-13 12:00 ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-11-13 13:02 ` Guido Guenther
2004-11-13 13:02 ` [Linux-fbdev-devel] " Guido Guenther
2004-11-13 18:00 ` Linus Torvalds
2004-11-13 21:29 ` Antonino A. Daplas
2004-11-13 21:29 ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-11-13 22:54 ` Guido Guenther
2004-11-13 22:54 ` [Linux-fbdev-devel] " Guido Guenther
2004-11-13 23:52 ` Benjamin Herrenschmidt
2004-11-13 23:52 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2004-11-13 23:49 ` Benjamin Herrenschmidt
2004-11-13 23:49 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2004-11-13 12:20 ` Yasushi SHOJI
2004-11-19 1:48 ` readl/writel: swap or not to swap (was: [PATCH] fbdev: Fix IO access in rivafb) Yasushi SHOJI
2004-11-19 4:09 ` readl/writel: swap or not to swap Jeff Garzik
2004-11-19 7:24 ` Yasushi SHOJI
2004-11-08 21:52 ` Benjamin Herrenschmidt [this message]
2004-11-08 23:07 ` [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb Giuseppe Bilotta
2004-11-13 23:22 ` Guido Guenther
2004-11-13 23:22 ` [Linux-fbdev-devel] " Guido Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1099950722.10262.166.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.