From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 3/3] net: phy: realtek: add hwmon support for temp sensor on RTL822x
Date: Sat, 11 Jan 2025 23:30:56 +0100 [thread overview]
Message-ID: <10b72540-3642-4811-8691-9fbcc72d513d@gmail.com> (raw)
In-Reply-To: <0834047d-5eee-4d27-99c3-5f92460f78c3@lunn.ch>
On 11.01.2025 22:52, Andrew Lunn wrote:
>> +config REALTEK_PHY_HWMON
>> + def_bool REALTEK_PHY && HWMON
>> + depends on !(REALTEK_PHY=y && HWMON=m)
>> + help
>> + Optional hwmon support for the temperature sensor
>
> We frequently end up with build problems with HWMON. All the other
> PHYs use:
>
> depends on HWMON || HWMON=n
>
The situation is different here. In the other cases HWMON is used from
the main source file. If HWMON=n, then the main source file can be
built as module or be built-in, and the stubs of the HWMON functions
are used.
In my case, if HWMON=n, I want REALTEK_PHY_HWMON to be n, because
then I omit building realtek_hwmon.c (see Makefile).
> We have not yet seen 0-day report issues with your earlier patchsets
> versions, but maybe we should keep it the same as all other PHYs? But
> maybe it is actually the same, if you apply De Morgan's Law?
>
> Andrew
Heiner
next prev parent reply other threads:[~2025-01-11 22:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 20:48 [PATCH net-next v2 0/3] net: phy: realtek: add hwmon support Heiner Kallweit
2025-01-11 20:49 ` [PATCH net-next v2 1/3] net: phy: realtek: add support for reading MDIO_MMD_VEND2 regs on RTL8125/RTL8126 Heiner Kallweit
2025-01-11 21:41 ` Andrew Lunn
2025-01-11 20:50 ` [PATCH net-next v2 2/3] net: phy: move realtek PHY driver to its own subdirectory Heiner Kallweit
2025-01-11 21:42 ` Andrew Lunn
2025-01-11 20:51 ` [PATCH net-next v2 3/3] net: phy: realtek: add hwmon support for temp sensor on RTL822x Heiner Kallweit
2025-01-11 21:52 ` Andrew Lunn
2025-01-11 22:30 ` Heiner Kallweit [this message]
2025-01-12 16:39 ` Andrew Lunn
2025-01-21 16:10 ` Geert Uytterhoeven
2025-01-23 20:12 ` Heiner Kallweit
2025-01-14 23:00 ` [PATCH net-next v2 0/3] net: phy: realtek: add hwmon support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10b72540-3642-4811-8691-9fbcc72d513d@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.