From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64A5DC433EF for ; Wed, 18 May 2022 08:28:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF89C113EAB; Wed, 18 May 2022 08:28:16 +0000 (UTC) Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D90711275F for ; Wed, 18 May 2022 08:28:14 +0000 (UTC) Received: by mail-ej1-x62e.google.com with SMTP id tk15so2309834ejc.6 for ; Wed, 18 May 2022 01:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to; bh=bCanf3NiI9fQe+bkEVG7ewAGAZDg/iNX82ODNhkKytg=; b=M5swUcMtgso1h9v50XtAtm6QuW7G4aJ0fpSe2FRvNZJVnhNGew0iDgyzEMFewR7DNt BV+Ge8c9SvNqWwvnTGSRuRPHUhl+V79cBy0/oPBp0mQIWBzakLcU/0o/AYJoJ81CXSoW iZOC7jPcsPilCyT2IirR4eyGm/tEu8UU6Hqn8g9R4ClS7mdpAlVxQogCe9H9z5HqQkU9 cZFSaV7z6t+yV1jIFCV+OAnkPQPeVF7XuFgw9Xpnu4QeluCWUeRtD64XT76IzcxuLh05 8QTb74bZ2aq4KBxJhwXQ07P2WD+L10jZjo7Mv/3pjQh985QcFvKHTc56xpTVxaWFDSI2 TtIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to; bh=bCanf3NiI9fQe+bkEVG7ewAGAZDg/iNX82ODNhkKytg=; b=fhKlncKUirshHs2gPrpHWK/HDGXtoEO+AK2IOO3Wo8+UhH1ZS6kMiMSUkdpnWp7zKr i/0+hsFK4hE1XtfO6KwCuzyGGRC/nepOimxe/o/5ze86jidDwwVRoAM7wu0FKksCXs/a gIjviFgqAmZ2RJm7d+bBm39MTed0E++b8u5d+lUrIqNNl6sHVNy2nemipLtZ42L6lQEA 9cc2jf4lhMdpm4junt+UFhbTz032OHWWOASeNpUad5gOV8FLJbgVGiaJ2XzfqyoliRGF FftfwSBjwb9+X4yRxa9hbL20ENZJpFUPKoUqwuZlV31BPLGu63+i+p7BnfzfHPpRwipK rIgg== X-Gm-Message-State: AOAM531K+aXnHD9avHMIfQ5vaD0bBhhK34oEu0WuUMHj8GxFU1kgxSXN 8HeICgKlEnZ1/JmMQUR3nak= X-Google-Smtp-Source: ABdhPJwlBBRBgx150C3LHc/0CkeJ8a/OJtDXPTZA/SHnhFH+RAVTe6cbULxFqvTgcBfmGzITLw8EBg== X-Received: by 2002:a17:907:2d24:b0:6f4:3152:3d1a with SMTP id gs36-20020a1709072d2400b006f431523d1amr23105172ejc.324.1652862492878; Wed, 18 May 2022 01:28:12 -0700 (PDT) Received: from [192.168.178.21] (p57b0bdaa.dip0.t-ipconnect.de. [87.176.189.170]) by smtp.gmail.com with ESMTPSA id n21-20020aa7c455000000b0042ac2705444sm942791edr.58.2022.05.18.01.28.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 01:28:12 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------EQYh5EmqLWY3rAeOhdBiZmug" Message-ID: <10bbba92-b02e-115b-3584-c6ac36236594@gmail.com> Date: Wed, 18 May 2022 10:28:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/3] drm/amdgpu: add AMDGPU_VM_NOALLOC Content-Language: en-US From: =?UTF-8?Q?Christian_K=c3=b6nig?= To: =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= References: <20220506112312.347519-1-christian.koenig@amd.com> <20220506112312.347519-2-christian.koenig@amd.com> <8695802e-6835-a717-c0ee-83b76d8a8875@gmail.com> <5941d83c-6d2b-6e3b-bd5c-b22779929d5e@amd.com> <083064af-c8b7-b5a3-0351-45392478260f@gmail.com> In-Reply-To: <083064af-c8b7-b5a3-0351-45392478260f@gmail.com> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Lazar, Lijo" , amd-gfx mailing list Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" This is a multi-part message in MIME format. --------------EQYh5EmqLWY3rAeOhdBiZmug Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Found and fixed. If nobody has any more objections are batter names for the new flags I'm going to push this to amd-staging-drm-next tomorrow. Thanks, Christian. Am 17.05.22 um 08:33 schrieb Christian König: > Ok that sounds like a rather simple bug. I will try to take a look. > > Thanks, > Christian. > > Am 17.05.22 um 02:12 schrieb Marek Olšák: >> Dmesg doesn't contain anything. There is no backtrace because it's >> not a crash. The VA map ioctl just fails with the new flag. It looks >> like the flag is considered invalid. >> >> Marek >> >> On Mon., May 16, 2022, 12:13 Christian König, >> wrote: >> >> I don't have access to any gfx10 hardware. >> >> Can you give me a dmesg and/or backtrace, etc..? >> >> I can't push this unless it's working properly. >> >> Christian. >> >> Am 16.05.22 um 14:56 schrieb Marek Olšák: >>> Reproduction steps: >>> - use mesa/main on gfx10.3 (not sure what other GPUs do) >>> - run: radeonsi_mall_noalloc=true glxgears >>> >>> Marek >>> >>> On Mon, May 16, 2022 at 7:53 AM Christian König >>> wrote: >>> >>> Crap, do you have a link to the failure? >>> >>> Am 16.05.22 um 13:10 schrieb Marek Olšák: >>>> I forgot to say: The NOALLOC flag causes an allocation >>>> failure, so there is a kernel bug somewhere. >>>> >>>> Marek >>>> >>>> On Mon, May 16, 2022 at 7:06 AM Marek Olšák >>>> wrote: >>>> >>>> FYI, I think it's time to merge this because the Mesa >>>> commits are going to be merged in ~30 minutes if Gitlab >>>> CI is green, and that includes updated amdgpu_drm.h. >>>> >>>> Marek >>>> >>>> On Wed, May 11, 2022 at 2:55 PM Marek Olšák >>>> wrote: >>>> >>>> Ok sounds good. >>>> >>>> Marek >>>> >>>> On Wed., May 11, 2022, 03:43 Christian König, >>>> wrote: >>>> >>>> It really *is* a NOALLOC feature. In other >>>> words there is no latency improvement on reads >>>> because the cache is always checked, even with >>>> the noalloc flag set. >>>> >>>> The only thing it affects is that misses not >>>> enter the cache and so don't cause any >>>> additional pressure on evicting cache lines. >>>> >>>> You might want to double check with the >>>> hardware guys, but I'm something like 95% sure >>>> that it works this way. >>>> >>>> Christian. >>>> >>>> Am 11.05.22 um 09:22 schrieb Marek Olšák: >>>>> Bypass means that the contents of the cache >>>>> are ignored, which decreases latency at the >>>>> cost of no coherency between bypassed and >>>>> normal memory requests. NOA (noalloc) means >>>>> that the cache is checked and can give you >>>>> cache hits, but misses are not cached and the >>>>> overall latency is higher. I don't know what >>>>> the hw does, but I hope it was misnamed and it >>>>> really means bypass because there is no point >>>>> in doing cache lookups on every memory request >>>>> if the driver wants to disable caching to >>>>> *decrease* latency in the situations when the >>>>> cache isn't helping. >>>>> >>>>> Marek >>>>> >>>>> On Wed, May 11, 2022 at 2:15 AM Lazar, Lijo >>>>> wrote: >>>>> >>>>> >>>>> >>>>> On 5/11/2022 11:36 AM, Christian König wrote: >>>>> > Mhm, it doesn't really bypass MALL. It >>>>> just doesn't allocate any MALL >>>>> > entries on write. >>>>> > >>>>> > How about AMDGPU_VM_PAGE_NO_MALL ? >>>>> >>>>> One more - AMDGPU_VM_PAGE_LLC_* [ LLC = >>>>> last level cache, * = some sort >>>>> of attribute which decides LLC behaviour] >>>>> >>>>> Thanks, >>>>> Lijo >>>>> >>>>> > >>>>> > Christian. >>>>> > >>>>> > Am 10.05.22 um 23:21 schrieb Marek Olšák: >>>>> >> A better name would be: >>>>> >> AMDGPU_VM_PAGE_BYPASS_MALL >>>>> >> >>>>> >> Marek >>>>> >> >>>>> >> On Fri, May 6, 2022 at 7:23 AM >>>>> Christian König >>>>> >> wrote: >>>>> >> >>>>> >>     Add the AMDGPU_VM_NOALLOC flag to >>>>> let userspace control MALL >>>>> >>     allocation. >>>>> >> >>>>> >>     Only compile tested! >>>>> >> >>>>> >>  Signed-off-by: Christian König >>>>> >>>>> >>     --- >>>>> >> >>>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >>>>> | 2 ++ >>>>> >> >>>>>   drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | >>>>> 3 +++ >>>>> >> >>>>>   drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | >>>>> 3 +++ >>>>> >>   include/uapi/drm/amdgpu_drm.h         >>>>>  | 2 ++ >>>>> >>      4 files changed, 10 insertions(+) >>>>> >> >>>>> >>     diff --git >>>>> a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >>>>> >>  b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >>>>> >>     index bf97d8f07f57..d8129626581f 100644 >>>>> >>     --- >>>>> a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >>>>> >>     +++ >>>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >>>>> >>     @@ -650,6 +650,8 @@ uint64_t >>>>> amdgpu_gem_va_map_flags(struct >>>>> >>  amdgpu_device *adev, uint32_t flags) >>>>> >>     pte_flag |= AMDGPU_PTE_WRITEABLE; >>>>> >>             if (flags & AMDGPU_VM_PAGE_PRT) >>>>> >>     pte_flag |= AMDGPU_PTE_PRT; >>>>> >>     +       if (flags & >>>>> AMDGPU_VM_PAGE_NOALLOC) >>>>> >>     +      pte_flag |= AMDGPU_PTE_NOALLOC; >>>>> >> >>>>> >>             if >>>>> (adev->gmc.gmc_funcs->map_mtype) >>>>> >>     pte_flag |= amdgpu_gmc_map_mtype(adev, >>>>> >>     diff --git >>>>> a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c >>>>> >>  b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c >>>>> >>     index b8c79789e1e4..9077dfccaf3c 100644 >>>>> >>     --- >>>>> a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c >>>>> >>     +++ >>>>> b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c >>>>> >>     @@ -613,6 +613,9 @@ static void >>>>> gmc_v10_0_get_vm_pte(struct >>>>> >>  amdgpu_device *adev, >>>>> >> *flags &= ~AMDGPU_PTE_MTYPE_NV10_MASK; >>>>> >> *flags |= (mapping->flags & >>>>> AMDGPU_PTE_MTYPE_NV10_MASK); >>>>> >> >>>>> >>     +  *flags &= ~AMDGPU_PTE_NOALLOC; >>>>> >>     +  *flags |= (mapping->flags & >>>>> AMDGPU_PTE_NOALLOC); >>>>> >>     + >>>>> >>             if (mapping->flags & >>>>> AMDGPU_PTE_PRT) { >>>>> >>     *flags |= AMDGPU_PTE_PRT; >>>>> >>     *flags |= AMDGPU_PTE_SNOOPED; >>>>> >>     diff --git >>>>> a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c >>>>> >>  b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c >>>>> >>     index 8d733eeac556..32ee56adb602 100644 >>>>> >>     --- >>>>> a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c >>>>> >>     +++ >>>>> b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c >>>>> >>     @@ -508,6 +508,9 @@ static void >>>>> gmc_v11_0_get_vm_pte(struct >>>>> >>  amdgpu_device *adev, >>>>> >> *flags &= ~AMDGPU_PTE_MTYPE_NV10_MASK; >>>>> >> *flags |= (mapping->flags & >>>>> AMDGPU_PTE_MTYPE_NV10_MASK); >>>>> >> >>>>> >>     +  *flags &= ~AMDGPU_PTE_NOALLOC; >>>>> >>     +  *flags |= (mapping->flags & >>>>> AMDGPU_PTE_NOALLOC); >>>>> >>     + >>>>> >>             if (mapping->flags & >>>>> AMDGPU_PTE_PRT) { >>>>> >>     *flags |= AMDGPU_PTE_PRT; >>>>> >>     *flags |= AMDGPU_PTE_SNOOPED; >>>>> >>     diff --git >>>>> a/include/uapi/drm/amdgpu_drm.h >>>>> >>  b/include/uapi/drm/amdgpu_drm.h >>>>> >>     index 57b9d8f0133a..9d71d6330687 100644 >>>>> >>     --- a/include/uapi/drm/amdgpu_drm.h >>>>> >>     +++ b/include/uapi/drm/amdgpu_drm.h >>>>> >>     @@ -533,6 +533,8 @@ struct >>>>> drm_amdgpu_gem_op { >>>>> >>      #define AMDGPU_VM_MTYPE_UC       >>>>>  (4 << 5) >>>>> >>      /* Use Read Write MTYPE instead of >>>>> default MTYPE */ >>>>> >>      #define AMDGPU_VM_MTYPE_RW       >>>>>  (5 << 5) >>>>> >>     +/* don't allocate MALL */ >>>>> >>     +#define AMDGPU_VM_PAGE_NOALLOC     >>>>>    (1 << 9) >>>>> >> >>>>> >>      struct drm_amdgpu_gem_va { >>>>> >>             /** GEM object handle */ >>>>> >>     -- >>>>> >>     2.25.1 >>>>> >> >>>>> > >>>>> >>>> >>> >> > --------------EQYh5EmqLWY3rAeOhdBiZmug Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit Found and fixed. If nobody has any more objections are batter names for the new flags I'm going to push this to amd-staging-drm-next tomorrow.

Thanks,
Christian.

Am 17.05.22 um 08:33 schrieb Christian König:
Ok that sounds like a rather simple bug. I will try to take a look.

Thanks,
Christian.

Am 17.05.22 um 02:12 schrieb Marek Olšák:
Dmesg doesn't contain anything. There is no backtrace because it's not a crash. The VA map ioctl just fails with the new flag. It looks like the flag is considered invalid.

Marek

On Mon., May 16, 2022, 12:13 Christian König, <ckoenig.leichtzumerken@gmail.com> wrote:
I don't have access to any gfx10 hardware.

Can you give me a dmesg and/or backtrace, etc..?

I can't push this unless it's working properly.

Christian.

Am 16.05.22 um 14:56 schrieb Marek Olšák:
Reproduction steps:
- use mesa/main on gfx10.3 (not sure what other GPUs do)
- run: radeonsi_mall_noalloc=true glxgears

Marek

On Mon, May 16, 2022 at 7:53 AM Christian König <ckoenig.leichtzumerken@gmail.com> wrote:
Crap, do you have a link to the failure?

Am 16.05.22 um 13:10 schrieb Marek Olšák:
I forgot to say: The NOALLOC flag causes an allocation failure, so there is a kernel bug somewhere.

Marek

On Mon, May 16, 2022 at 7:06 AM Marek Olšák <maraeo@gmail.com> wrote:
FYI, I think it's time to merge this because the Mesa commits are going to be merged in ~30 minutes if Gitlab CI is green, and that includes updated amdgpu_drm.h.

Marek

On Wed, May 11, 2022 at 2:55 PM Marek Olšák <maraeo@gmail.com> wrote:
Ok sounds good.

Marek

On Wed., May 11, 2022, 03:43 Christian König, <ckoenig.leichtzumerken@gmail.com> wrote:
It really *is* a NOALLOC feature. In other words there is no latency improvement on reads because the cache is always checked, even with the noalloc flag set.

The only thing it affects is that misses not enter the cache and so don't cause any additional pressure on evicting cache lines.

You might want to double check with the hardware guys, but I'm something like 95% sure that it works this way.

Christian.

Am 11.05.22 um 09:22 schrieb Marek Olšák:
Bypass means that the contents of the cache are ignored, which decreases latency at the cost of no coherency between bypassed and normal memory requests. NOA (noalloc) means that the cache is checked and can give you cache hits, but misses are not cached and the overall latency is higher. I don't know what the hw does, but I hope it was misnamed and it really means bypass because there is no point in doing cache lookups on every memory request if the driver wants to disable caching to *decrease* latency in the situations when the cache isn't helping.

Marek

On Wed, May 11, 2022 at 2:15 AM Lazar, Lijo <lijo.lazar@amd.com> wrote:


On 5/11/2022 11:36 AM, Christian König wrote:
> Mhm, it doesn't really bypass MALL. It just doesn't allocate any MALL
> entries on write.
>
> How about AMDGPU_VM_PAGE_NO_MALL ?

One more - AMDGPU_VM_PAGE_LLC_* [ LLC = last level cache, * = some sort
of attribute which decides LLC behaviour]

Thanks,
Lijo

>
> Christian.
>
> Am 10.05.22 um 23:21 schrieb Marek Olšák:
>> A better name would be:
>> AMDGPU_VM_PAGE_BYPASS_MALL
>>
>> Marek
>>
>> On Fri, May 6, 2022 at 7:23 AM Christian König
>> <ckoenig.leichtzumerken@gmail.com> wrote:
>>
>>     Add the AMDGPU_VM_NOALLOC flag to let userspace control MALL
>>     allocation.
>>
>>     Only compile tested!
>>
>>     Signed-off-by: Christian König <christian.koenig@amd.com>
>>     ---
>>      drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 ++
>>      drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c  | 3 +++
>>      drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c  | 3 +++
>>      include/uapi/drm/amdgpu_drm.h           | 2 ++
>>      4 files changed, 10 insertions(+)
>>
>>     diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>     b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>     index bf97d8f07f57..d8129626581f 100644
>>     --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>     +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
>>     @@ -650,6 +650,8 @@ uint64_t amdgpu_gem_va_map_flags(struct
>>     amdgpu_device *adev, uint32_t flags)
>>                     pte_flag |= AMDGPU_PTE_WRITEABLE;
>>             if (flags & AMDGPU_VM_PAGE_PRT)
>>                     pte_flag |= AMDGPU_PTE_PRT;
>>     +       if (flags & AMDGPU_VM_PAGE_NOALLOC)
>>     +               pte_flag |= AMDGPU_PTE_NOALLOC;
>>
>>             if (adev->gmc.gmc_funcs->map_mtype)
>>                     pte_flag |= amdgpu_gmc_map_mtype(adev,
>>     diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
>>     b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
>>     index b8c79789e1e4..9077dfccaf3c 100644
>>     --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
>>     +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
>>     @@ -613,6 +613,9 @@ static void gmc_v10_0_get_vm_pte(struct
>>     amdgpu_device *adev,
>>             *flags &= ~AMDGPU_PTE_MTYPE_NV10_MASK;
>>             *flags |= (mapping->flags & AMDGPU_PTE_MTYPE_NV10_MASK);
>>
>>     +       *flags &= ~AMDGPU_PTE_NOALLOC;
>>     +       *flags |= (mapping->flags & AMDGPU_PTE_NOALLOC);
>>     +
>>             if (mapping->flags & AMDGPU_PTE_PRT) {
>>                     *flags |= AMDGPU_PTE_PRT;
>>                     *flags |= AMDGPU_PTE_SNOOPED;
>>     diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
>>     b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
>>     index 8d733eeac556..32ee56adb602 100644
>>     --- a/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
>>     +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c
>>     @@ -508,6 +508,9 @@ static void gmc_v11_0_get_vm_pte(struct
>>     amdgpu_device *adev,
>>             *flags &= ~AMDGPU_PTE_MTYPE_NV10_MASK;
>>             *flags |= (mapping->flags & AMDGPU_PTE_MTYPE_NV10_MASK);
>>
>>     +       *flags &= ~AMDGPU_PTE_NOALLOC;
>>     +       *flags |= (mapping->flags & AMDGPU_PTE_NOALLOC);
>>     +
>>             if (mapping->flags & AMDGPU_PTE_PRT) {
>>                     *flags |= AMDGPU_PTE_PRT;
>>                     *flags |= AMDGPU_PTE_SNOOPED;
>>     diff --git a/include/uapi/drm/amdgpu_drm.h
>>     b/include/uapi/drm/amdgpu_drm.h
>>     index 57b9d8f0133a..9d71d6330687 100644
>>     --- a/include/uapi/drm/amdgpu_drm.h
>>     +++ b/include/uapi/drm/amdgpu_drm.h
>>     @@ -533,6 +533,8 @@ struct drm_amdgpu_gem_op {
>>      #define AMDGPU_VM_MTYPE_UC             (4 << 5)
>>      /* Use Read Write MTYPE instead of default MTYPE */
>>      #define AMDGPU_VM_MTYPE_RW             (5 << 5)
>>     +/* don't allocate MALL */
>>     +#define AMDGPU_VM_PAGE_NOALLOC         (1 << 9)
>>
>>      struct drm_amdgpu_gem_va {
>>             /** GEM object handle */
>>     --
>>     2.25.1
>>
>





--------------EQYh5EmqLWY3rAeOhdBiZmug--