From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC][PATCH 0/5 v2] adv7511 EDID probing improvements Date: Mon, 12 Dec 2016 14:10:44 +0530 Message-ID: <10bc366d-9955-1f03-7136-9fb05eee943f@codeaurora.org> References: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id F325F6E28F for ; Mon, 12 Dec 2016 08:40:50 +0000 (UTC) In-Reply-To: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz , lkml Cc: Wolfram Sang , Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiAxMS8yOS8yMDE2IDEwOjM0IEFNLCBKb2huIFN0dWx0eiB3cm90ZToKPiBXYW50ZWQg dG8gc2VuZCBvdXQgdjIgb2YgdGhpcyBwYXRjaCBzZXQgaW1wcm92aW5nIHRoZSBFRElECj4gcHJv YmluZyBvbiB0aGUgYWR2NzUxMSB1c2VkIG9uIEhpS2V5Lgo+Cj4gVGhlIGZpcnN0IHRocmVlIHBh dGNoZXMgYXJlIGZpeHVwcyB0aGF0IGFyZSBob3BlZnVsbHkgc3RyYWlnaHQKPiBmb3J3YXJkLCBp bnRlZ3JhdGluZyBmZWVkYmFjayBJIGdvdCBmcm9tIExhdXJhbnQuCj4KPiBPbmUgb2YgdGhlIHBy ZXZpb3VzIHBhdGNoZXMgdGhhdCBMYXVyYW50IGhhZCBjb25jZXJucyBhYm91dCwgSQo+IGJyb2tl IGludG8gdHdvIHBhdGNoZXMsIHdoaWNoIGFyZSB0aGUgbGFzdCB0d28gaW4gdGhpcyBzZXJpZXMu Cj4gVGhlIGNvcmUgaXNzdWUgc2VlbXMgdG8gYmUgc29tZXRoaW5nIGdvaW5nIHdyb25nIHdpdGgg dGhlIHJlZ21hcAo+IGNhY2hlIHN0YXRlIGZvciB0aGUgQURWNzUxMV9SRUdfRURJRF9JMkNfQURE UiAoMHg0MykgcmVnaXN0ZXIKPiB3aGljaCByZXN1bHRzIGluIGkyY190cmFuc2ZlciBlcnJvcnMg aWYgd2UgZG9uJ3QgZG8gdGhlCj4gcmVnY2FjaGVfc3luYy9fbWFya19kaXJ0eSgpIGNhbGxzLiBJ IHN1c3BlY3QgdGhlcmUgbWlnaHQgYmUgYQo+IGJldHRlciBzb2x1dGlvbiB0aGVyZSwgc28gc3Vn Z2VzdGlvbnMgd2lsbCBiZSB2ZXJ5IHdlbGNvbWUuCj4KPiBUaG91Z2h0cyBhbmQgZmVlZGJhY2sg d291bGQgYmUgYXBwcmVjaWF0ZWQhCgpJIHRlc3RlZCB0aGlzIGZvciBBRFY3NTMzIG9uIERCNDEw YyBhbmQgaXQgd29ya3Mgd2VsbC4gV2UgY2FuCnB1bGwgdGhpcyBpZiBpdCB3b3JrcyBmaW5lIGZv ciBBRFY3NTExIHRvby4gTGF1cmVudCwgY291bGQgd2UKZ2V0IGFuIEFjayBmb3IgdGhlIHNlcmll cyBmcm9tIHlvdT8KClRoYW5rcywKQXJjaGl0Cgo+Cj4gdGhhbmtzCj4gLWpvaG4KPgo+IENjOiBE YXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IEFyY2hpdCBUYW5lamEgPGFyY2hp dHRAY29kZWF1cm9yYS5vcmc+Cj4gQ2M6IFdvbGZyYW0gU2FuZyA8d3NhK3JlbmVzYXNAc2FuZy1l bmdpbmVlcmluZy5jb20+Cj4gQ2M6IExhcnMtUGV0ZXIgQ2xhdXNlbiA8bGFyc0BtZXRhZm9vLmRl Pgo+IENjOiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5j b20+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPgo+IEFyY2hpdCBUYW5l amEgKDEpOgo+ICAgZHJtL2JyaWRnZTogYWR2NzUxMTogRW5hYmxlIEhQRCBpbnRlcnJ1cHRzIHRv IHN1cHBvcnQgaG90cGx1ZyBhbmQKPiAgICAgaW1wcm92ZSBtb25pdG9yIGRldGVjdGlvbgo+Cj4g Sm9obiBTdHVsdHogKDQpOgo+ICAgZHJtL2JyaWRnZTogYWR2NzUxMTogVXNlIHdvcmtfc3RydWN0 IHRvIGRlZmVyIGhvdHBsdWcgaGFuZGluZyB0byBvdXQKPiAgICAgb2YgaXJxIGNvbnRleHQKPiAg IGRybS9icmlkZ2U6IGFkdjc1MTE6IFN3aXRjaCB0byB1c2luZyBkcm1fa21zX2hlbHBlcl9ob3Rw bHVnX2V2ZW50KCkKPiAgIGRybS9icmlkZ2U6IGFkdjc1MTE6IFJld29yayBhZHY3NTExX3Bvd2Vy X29uL29mZigpIHNvIHRoZXkgY2FuIGJlCj4gICAgIHJldXNlZCBpbnRlcm5hbGx5Cj4gICBkcm0v YnJpZGdlOiBhZHY3NTExOiBSZXVzZSBfX2Fkdjc1MTFfcG93ZXJfb24vb2ZmKCkgd2hlbiBwcm9i aW5nIEVESUQKPgo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMS5oICAg ICB8ICAyICsrCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5j IHwgNDkgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDMx IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+CgotLSAKUXVhbGNvbW0gSW5ub3ZhdGlv biBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sCmEgTGludXgg Rm91bmRhdGlvbiBDb2xsYWJvcmF0aXZlIFByb2plY3QKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932172AbcLLIkx (ORCPT ); Mon, 12 Dec 2016 03:40:53 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33772 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbcLLIkv (ORCPT ); Mon, 12 Dec 2016 03:40:51 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 391CC612E7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [RFC][PATCH 0/5 v2] adv7511 EDID probing improvements To: John Stultz , lkml References: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> Cc: David Airlie , Wolfram Sang , Lars-Peter Clausen , Laurent Pinchart , dri-devel@lists.freedesktop.org From: Archit Taneja Message-ID: <10bc366d-9955-1f03-7136-9fb05eee943f@codeaurora.org> Date: Mon, 12 Dec 2016 14:10:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/29/2016 10:34 AM, John Stultz wrote: > Wanted to send out v2 of this patch set improving the EDID > probing on the adv7511 used on HiKey. > > The first three patches are fixups that are hopefully straight > forward, integrating feedback I got from Laurant. > > One of the previous patches that Laurant had concerns about, I > broke into two patches, which are the last two in this series. > The core issue seems to be something going wrong with the regmap > cache state for the ADV7511_REG_EDID_I2C_ADDR (0x43) register > which results in i2c_transfer errors if we don't do the > regcache_sync/_mark_dirty() calls. I suspect there might be a > better solution there, so suggestions will be very welcome. > > Thoughts and feedback would be appreciated! I tested this for ADV7533 on DB410c and it works well. We can pull this if it works fine for ADV7511 too. Laurent, could we get an Ack for the series from you? Thanks, Archit > > thanks > -john > > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolfram Sang > Cc: Lars-Peter Clausen > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > > Archit Taneja (1): > drm/bridge: adv7511: Enable HPD interrupts to support hotplug and > improve monitor detection > > John Stultz (4): > drm/bridge: adv7511: Use work_struct to defer hotplug handing to out > of irq context > drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event() > drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be > reused internally > drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID > > drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 ++ > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 49 ++++++++++++++++------------ > 2 files changed, 31 insertions(+), 20 deletions(-) > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project